[cmake-developers] CPack IFW generator

[Nils Gladitz]

On 05/12/2014 04:33 PM, Brad King wrote:
> I'd appreciate comments from others on this mailing list that
> have worked on developing CPack generators.  Also, I'm not
> familiar with IFW so I can only comment on this from the
> CMake/CPack side.

I am not familiar with IFW either but ...

Some minor superficial stuff:
- The NSIS specific comments should be removed

- IFW_OPT seems to be unused and could be removed(?)

- There is a lot of uncommented code that should be removed

- The check that determines if IFW_BINARYCREATOR_EXECUTABLE was found 
doesn't work since it is set to "IFW_BINARYCREATOR_EXECUTABLE-NOTFOUND" 
rather than empty (I think I have to reevaluate that in the WIX 
Generator as well). IsOn() should work.

- "Crator" -> "Creator"

- Line lengths and braces don't match the coding conventions everywhere yet

- Some of the XML content looks like it might require escaping e.g. in:
   "    <Name>" << ifwPkgName << "</Name>"
   with cmXMLSafe(ifwPkgName)

I created an installer for CMake itself (on linux) where I noticed:

- Default install prefix is "/CMake"; I expected a default prefix of 
/usr/local

- There is a component selection dialog even though components don't 
seem to be supported by the generator yet. Could it be omitted?

- In the "Show Details" summary I get:
   Selected Component(s) without Dependencies
   root

Could/should "root" be replaced with the content of CPACK_PACKAGE_NAME?

Nils