View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0016132

CMake

public

2016-05-29 21:14

2016-06-10 14:21

Reporter

Craig Scott

Assigned To

Priority

normal

Severity

trivial

Reproducibility

N/A

Status

closed

Resolution

fixed

Platform

Windows

OS Version

Product Version

CMake 3.5.2

Target Version

CMake 3.7

Fixed in Version

CMake 3.7

Summary

0016132: Repeated lines in NSIS.template.in

Description

At around line 160 of NSIS.template.in, the block of code below appears to repeat the same thing (probably the result of a bad merge at some point). Seems like one of the two blocks should be removed?

;--------------------------------
; path functions

!verbose 3
!include "WinMessages.NSH"
!verbose 4

;----------------------------------------
; based upon a script of "Written by KiCHiK 2003-01-18 05:57:02"
;----------------------------------------
!verbose 3
!include "WinMessages.NSH"
!verbose 4

Tags

No tags attached.

Attached Files

Relationships

Notes
(0041128) Brad King (manager) 2016-06-02 11:51	Thanks for pointing this out. Fixed: CPack/NSIS: Remove duplicate include from NSIS.template.in https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=e847b6c8 [^]

(0041159) Kitware Robot (administrator) 2016-06-10 14:21	This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

Issue History
Date Modified	Username	Field	Change
2016-05-29 21:14	Craig Scott	New Issue
2016-06-02 11:51	Brad King	Note Added: 0041128
2016-06-02 11:51	Brad King	Status	new => resolved
2016-06-02 11:51	Brad King	Resolution	open => fixed
2016-06-02 11:51	Brad King	Fixed in Version	=> CMake 3.7
2016-06-02 11:51	Brad King	Target Version	=> CMake 3.7
2016-06-10 14:21	Kitware Robot	Note Added: 0041159
2016-06-10 14:21	Kitware Robot	Status	resolved => closed