View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0015811CMakeCMakepublic2015-10-27 14:452016-03-07 09:12
ReporterAndrew S. 
Assigned ToGilles Khouzam 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformWinRTOSOS Version
Product VersionCMake 3.3.2 
Target VersionCMake 3.5Fixed in VersionCMake 3.5 
Summary0015811: Add support for resw files for Windows RT & Windows Phone platforms
DescriptionHI!

I have a problem with Visual Studio generator for resw files (xml files which are used for app localisation). The generator writes <None ... element for a resw file instead of <PRIResource ..

Fix is straightforward, see it here:

https://github.com/mad-rain/CMake/commit/afda6af62ad84bc96e1a0bf1d51da73ac94896fe [^]

We have tested it - works just fine for our project.

I hope to see it merge before 3.4.0 release.

Thanks.


TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0039687)
Gilles Khouzam (developer)
2015-10-27 15:21

The change looks good and trivial. I agree that it would be nice to have for 3.4.
For 3.5, I'm looking at also adding a more generic model so that new file types might not require a change to the binaries.
(0039700)
Brad King (manager)
2015-10-28 15:20

Patch applied here:

 VS: Add support for `.resw` files
 https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=77dde5cb [^]
(0040631)
Robert Maynard (manager)
2016-03-07 09:12

Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2015-10-27 14:45 Andrew S. New Issue
2015-10-27 14:57 Brad King Assigned To => Gilles Khouzam
2015-10-27 14:57 Brad King Status new => assigned
2015-10-27 14:57 Brad King Target Version => CMake 3.5
2015-10-27 15:21 Gilles Khouzam Note Added: 0039687
2015-10-28 15:20 Brad King Note Added: 0039700
2015-10-28 15:20 Brad King Status assigned => resolved
2015-10-28 15:20 Brad King Resolution open => fixed
2015-10-28 15:20 Brad King Fixed in Version => CMake 3.5
2016-03-07 09:12 Robert Maynard Note Added: 0040631
2016-03-07 09:12 Robert Maynard Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team