View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0015542 | CMake | CMake | public | 2015-04-29 15:01 | 2015-11-02 09:13 | ||||
Reporter | Felix Geyer | ||||||||
Assigned To | Brad King | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | CMake 3.2.2 | ||||||||
Target Version | CMake 3.3 | Fixed in Version | CMake 3.3 | ||||||
Summary | 0015542: RunCMake tests fail when run with MAKEFLAGS='--jobserver-fds=' in environment | ||||||||
Description | When run in parallel these tests from the CMake test suite fail: 286 - RunCMake.Configure (Failed) 326 - RunCMake.try_compile (Failed) 335 - RunCMake.configure_file (Failed) Verified on Debian 8. Full build log is attached. | ||||||||
Steps To Reproduce | make -j4 test | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | cmake_build.log [^] (52,836 bytes) 2015-04-29 15:01 | ||||||||
Relationships | |
Relationships |
Notes | |
(0038645) Brad King (manager) 2015-04-29 15:17 |
I run CMake's test suite in parallel all the time on Debian 'testing' and see no such failures. |
(0038647) Brad King (manager) 2015-04-29 15:30 |
The log contains lines like: actual-out> make[3]: Entering directory '/tmp/buildd/cmake-3.2.2/Build/Tests/RunCMake/configure_file/RerunCMake-build' actual-out> make[3]: Leaving directory '/tmp/buildd/cmake-3.2.2/Build/Tests/RunCMake/configure_file/RerunCMake-build' ... actual-err> make[3]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule. Is some environment variable set that GNU make interprets? |
(0038648) Brad King (manager) 2015-04-29 16:10 |
I can reproduce this with: $ MAKEFLAGS='--print-directory --jobserver-fds=9,10 -j' bin/ctest -R RunCMake.configure_file -V Why is MAKEFLAGS set when running ctest? |
(0038649) Felix Geyer (reporter) 2015-04-29 16:15 |
I think I found the difference. The Debian package debhelper tool calls this when running the tests: make -j4 test 'ARGS="-E CTestTestUpload -j4"' This fails with the error I posted. Running this works fine: make test 'ARGS="-E CTestTestUpload -j4"' |
(0038650) Brad King (manager) 2015-04-29 16:16 |
This should fix it: Tests: Protect RunCMake tests from MAKEFLAGS in environment http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=703e7625 [^] |
(0038651) Brad King (manager) 2015-04-29 16:22 |
Re 0015542:0038649: Thanks. Even with $ make --version GNU Make 4.0 $ make -j4 test ARGS="-R RunCMake.configure_file -V" I don't see the failure. Either way, I think the change linked in 0015542:0038650 should fix this. These tests are checking that 'make' prints what we expect, and this environment variable can cause 'make' to print extra output. |
(0038652) Felix Geyer (reporter) 2015-04-29 16:28 |
Thanks, works fine with your change. |
(0039797) Robert Maynard (manager) 2015-11-02 09:13 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2015-04-29 15:01 | Felix Geyer | New Issue | |
2015-04-29 15:01 | Felix Geyer | File Added: cmake_build.log | |
2015-04-29 15:17 | Brad King | Note Added: 0038645 | |
2015-04-29 15:30 | Brad King | Note Added: 0038647 | |
2015-04-29 16:10 | Brad King | Note Added: 0038648 | |
2015-04-29 16:15 | Felix Geyer | Note Added: 0038649 | |
2015-04-29 16:16 | Brad King | Note Added: 0038650 | |
2015-04-29 16:18 | Brad King | Assigned To | => Brad King |
2015-04-29 16:18 | Brad King | Status | new => resolved |
2015-04-29 16:18 | Brad King | Resolution | open => fixed |
2015-04-29 16:18 | Brad King | Fixed in Version | => CMake 3.3 |
2015-04-29 16:18 | Brad King | Target Version | => CMake 3.3 |
2015-04-29 16:18 | Brad King | Summary | RunCMake tests fail when run in parallel => RunCMake tests fail when run with MAKEFLAGS='--jobserver-fds=' in environment |
2015-04-29 16:22 | Brad King | Note Added: 0038651 | |
2015-04-29 16:28 | Felix Geyer | Note Added: 0038652 | |
2015-11-02 09:13 | Robert Maynard | Note Added: 0039797 | |
2015-11-02 09:13 | Robert Maynard | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |