View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0014890 | CMake | CPack | public | 2014-04-18 11:23 | 2015-07-08 08:57 | ||||
Reporter | Nicolas H. | ||||||||
Assigned To | Nils Gladitz | ||||||||
Priority | normal | Severity | feature | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | x86_64 | OS | windows | OS Version | all | ||||
Product Version | CMake 2.8.12.2 | ||||||||
Target Version | Fixed in Version | CMake 3.3 | |||||||
Summary | 0014890: cpack, wix, It's not possible to patch directories (patch attached) | ||||||||
Description | on git/master/cmake 3.0 I want to create a shortcut in the startup menu, i have to declare <Directory Id="StartupFolder" Name="Startup"/> on TARGETDIR. I'm not able to do that as directory cannot be patched | ||||||||
Steps To Reproduce | add SET(CPACK_WIX_PATCH_FILE test.xml) in test.xml put <CPackWiXPatch> <CPackWiXFragment Id="TARGETDIR"> <Directory Id="StartupFolder" Name="Startup"/> </CPackWiXFragment> </CPackWiXPatch> directories.xml is not patched. | ||||||||
Additional Information | please be nice, it's the first time i contribute to cmake :-) | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | 0001-added-patch-support-for-directories.patch [^] (5,410 bytes) 2014-04-18 11:23 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0035759) Nils Gladitz (developer) 2014-04-22 09:24 |
Thank you for your report. Patching "real" directories that are part of the packaged file hierarchy and as explicitly created by the WIX generator should be working (In that regard the summary is a bit misleading). What so far is not supported is e.g. patching directories that implicitly exist and are referenced by well known windows installer properties. I have been reluctant to allow patching these since I am more likely to break patches that make use of them when extending the WIX generator. Your initial use case sounds valid and I would like to support it in some way. Would it be ok to restrict patching to "TARGETDIR" for now or if I were to add explicit first level support for startup folder entries? If I were to add TARGETDIR and/or other additional windows installer controlled directories I'd like to add explicit warnings to the documentation (or perhaps even a specific patch construct that makes the potential danger explicit) so that users are at least aware their patches might break with future releases. |
(0038026) Nils Gladitz (developer) 2015-02-23 14:24 |
http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=e6731f48 [^] implements a CPACK_STARTUP_SHORTCUTS installed file property which should cover your specific use case. I am marking this issue as resolved but feel free to open additional issues if you had additional use cases in mind which are not covered. |
(0039061) Robert Maynard (manager) 2015-07-08 08:57 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2014-04-18 11:23 | Nicolas H. | New Issue | |
2014-04-18 11:23 | Nicolas H. | File Added: 0001-added-patch-support-for-directories.patch | |
2014-04-18 11:26 | Brad King | Assigned To | => Nils Gladitz |
2014-04-18 11:26 | Brad King | Status | new => assigned |
2014-04-22 09:24 | Nils Gladitz | Note Added: 0035759 | |
2014-04-22 09:24 | Nils Gladitz | Severity | major => feature |
2015-02-23 14:24 | Nils Gladitz | Note Added: 0038026 | |
2015-02-23 14:24 | Nils Gladitz | Status | assigned => resolved |
2015-02-23 14:24 | Nils Gladitz | Fixed in Version | => CMake 3.3 |
2015-02-23 14:24 | Nils Gladitz | Resolution | open => fixed |
2015-07-08 08:57 | Robert Maynard | Note Added: 0039061 | |
2015-07-08 08:57 | Robert Maynard | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |