View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014782CMake(No Category)public2014-03-01 16:442015-07-08 08:57
ReporterXiaoming Wang 
Assigned ToDomen Vrankar 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSRPM base LinuxOS Version
Product VersionCMake 2.8.12.2 
Target VersionCMake 3.3Fixed in VersionCMake 3.3 
Summary0014782: CPack fails when install file/dir path has '@'
Descriptionpatch "https://public.kitware.com/Bug/file/4715/0001-CPackRPM-protect-character-in-filename-processed-in-.patch [^] fixed install path with double '@' problem. This patch is merged in CMake 2.8.12.2 (not sure other 2.8.12 and 2.8.12.1)
But in CMake 2.8.12.2 generating RPM spec.in changed to use @CPACK_RPM_INSTALL_FILES@ instead of expansion of ${CPACK_RPM_INSTALL_FILES@} in earlier cake version. These combination makes install path with '@' no longer works.

One of simple fix is just remove the patch in <CAMKE_HOME>/Modules/CPackRPM.cmake in 2.8.12.x.
Our company provide some crucial products in Big Data area for both Open Source and Enterprise users.
This bug breaks our builds on any systems with CMake 2.8.12.2 (possible CMake 2.8.12 or later).

We can handle it in our internal build systems now but it will be hard to community users who want to compile our code on their own environment.

It will be appreciated if this bug can be fixed in the future CMake release.
Steps To ReproduceFor build RPM base package and have install path with '@'. It can be reproduced on CMake 2.8.12.2 (probably 2.8.12 or later)
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0035227)
Brad King (manager)
2014-03-03 08:48

 The patch in question is:

 CPackRPM protect '@' character in filename processed in the spec file.
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=1703e069 [^]
(0037465)
Xiaoming Wang (reporter)
2014-12-15 21:18

 This bug also need to be fixed in CMake 3.x
(0037556)
Domen Vrankar (developer)
2015-01-05 07:10

 I've tested CPackRPM with @ characters on different locations in the paths and I'd say that this patch is no longer needed and is only causing invalid path expansion (@ symbols are not replaced recursively so no need for this patch).

I'll remove the patch and the problem should be fixed.
(0038048)
Brad King (manager)
2015-02-24 08:52

 CPackRPM: Drop explicit handling of '@' symbols that breaks them
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5857ca5e [^]
(0039062)
Robert Maynard (manager)
2015-07-08 08:57

 Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2014-03-01 16:44 Xiaoming Wang New Issue
2014-03-03 08:47 Brad King Assigned To => Eric NOULARD
2014-03-03 08:47 Brad King Status new => assigned
2014-03-03 08:48 Brad King Note Added: 0035227
2014-12-15 21:18 Xiaoming Wang Note Added: 0037465
2014-12-16 08:23 Brad King Assigned To Eric NOULARD => Domen Vrankar
2015-01-05 07:10 Domen Vrankar Note Added: 0037556
2015-02-24 08:52 Brad King Note Added: 0038048
2015-02-24 08:52 Brad King Status assigned => resolved
2015-02-24 08:52 Brad King Resolution open => fixed
2015-02-24 08:52 Brad King Fixed in Version => CMake 3.3
2015-02-24 08:52 Brad King Target Version => CMake 3.3
2015-07-08 08:57 Robert Maynard Note Added: 0039062
2015-07-08 08:57 Robert Maynard Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team