View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0014660

CMake

CPack

public

2013-12-19 12:44

2015-11-02 09:13

Reporter

Joe Nardone

Assigned To

Domen Vrankar

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Linux

CentOS

OS Version

6.4

Product Version

CMake 2.8.10

Target Version

Fixed in Version

CMake 3.3

Summary

0014660: File tree builder is too greedy with 'sed'

Description

CPackRPM uses the following crazy `find` command to build its file list:

execute_process(COMMAND find . -type f -o -type l -o (-type d -a -not ( -name "." ${_RPM_DIRS_TO_OMIT} ) )
                COMMAND sed s:.*/man.*/.*:&*:
                COMMAND sed s/\\.\\$.*\\$/\"\\1\"/
                WORKING_DIRECTORY "${WDIR}"
                OUTPUT_VARIABLE CPACK_RPM_INSTALL_FILES)

However, the first `sed` is too greedy. It will match any path with the text 'man' in it. Which is fine for man pages, but for, say, a company name with those letters in it (even if it's in the install prefix) it will match every single item, and wildcard them. This leads to lots of files getting included multiple times.

Steps To Reproduce

Any package that has something like:

set(CPACK_PACKAGING_INSTALL_PREFIX "/opt/manna")

should trigger it.

Tags

No tags attached.

Attached Files

Relationships

Notes
(0038571) Domen Vrankar (developer) 2015-04-21 09:33	Fixed with commit: http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=50eefbb [^] CPackRPM now only treats paths copied from brp-compress rpm script as man pages and permits additional paths to be added using variable CPACK_RPM_ADDITIONAL_MAN_DIRS (additional paths also have to be added to brp-compress or files on those paths won't be compressed).

(0039784) Robert Maynard (manager) 2015-11-02 09:13	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2013-12-19 12:44	Joe Nardone	New Issue
2015-01-14 17:35	Domen Vrankar	Assigned To	=> Domen Vrankar
2015-01-14 17:35	Domen Vrankar	Status	new => assigned
2015-04-21 09:33	Domen Vrankar	Note Added: 0038571
2015-04-21 09:33	Domen Vrankar	Status	assigned => resolved
2015-04-21 09:33	Domen Vrankar	Fixed in Version	=> CMake 3.3
2015-04-21 09:33	Domen Vrankar	Resolution	open => fixed
2015-11-02 09:13	Robert Maynard	Note Added: 0039784
2015-11-02 09:13	Robert Maynard	Status	resolved => closed