View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013962CMakeModulespublic2013-02-27 18:422013-10-07 10:03
ReporterMichael Tänzer 
Assigned ToBrad King 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionfixed 
PlatformMinGWOSWindowsOS VersionXP
Product VersionCMake 2.8.10 
Target VersionCMake 2.8.11Fixed in VersionCMake 2.8.11 
Summary0013962: Add support for objdump to GetPrerequisites.cmake to make it usable on MinGW without Visual Studio installed
DescriptionIf you only have a MinGW environment without Visual Studio installed on a Windows system the fixup_bundle() from BundleUtilities which in turn uses get_prerequisites() from GetPrerequisites won't work as intended because dumpbin is not available on the system. However MinGW comes with objdump which can be used instead.

I have implemented this in https://github.com/NEOatNHNG/CMake.git [^] get_prerequisites-add-objdump
Additional InformationA pull request is underway
TagsNo tags attached.
Attached Files

 Relationships

  Notes
(0032404)
Michael Tänzer (reporter)
2013-02-27 18:50

 https://github.com/Kitware/CMake/pull/35 [^]
(0032410)
Clinton Stimpson (developer)
2013-02-28 10:01

 Would you please also enable the BundleUtilities test for MinGW in CMake/Tests/CMakeLists.txt? It would be nice to add test coverage for this.
(0032411)
Brad King (manager)
2013-02-28 11:13

 Pull request placed upstream here:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=5260a864 [^]
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=33c94c82 [^]
(0032412)
Brad King (manager)
2013-02-28 11:14

 Re 0013962:0032410: Yes, Michael, please checkout the topic as of 33c94c82 and try enabling the test in your tree.
(0032421)
Michael Tänzer (reporter)
2013-03-01 10:35

 I have enabled the test on my branch. Please pull. Test ran successfully.
(0032422)
Clinton Stimpson (developer)
2013-03-01 10:45

 I don't see where you modified this chunk to add objdump support:
if("${gp_tool}" STREQUAL "")
    set(gp_tool "ldd")
    if(APPLE)
      set(gp_tool "otool")
    endif()
    if(WIN32 AND NOT UNIX) # This is how to check for cygwin, har!
      set(gp_tool "dumpbin")
    endif()
  endif()


Did the test pass on your machine because it found dumpbin?
(0032423)
Michael Tänzer (reporter)
2013-03-01 10:54

 I changed that logic in GetPrerequisites.cmake: https://github.com/NEOatNHNG/CMake/commit/33c94c82ba7d525e3435248c98132d87415e95a3 [^]
Is there another place that has it?

No I don't have Visual Studio installed on that machine so no dumpbin to be found.
(0032424)
Clinton Stimpson (developer)
2013-03-01 10:59

 I missed that.
Looks good.
(0032425)
Michael Tänzer (reporter)
2013-03-01 11:00

 Just noticed: Forgot to add objdump to the documentation. Fixed.
(0032427)
Brad King (manager)
2013-03-01 11:50

 Topic updates now in next:

 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=8eb2fe95 [^]
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=12fb50da [^]
(0032433)
Brad King (manager)
2013-03-04 08:16

 The topic was clean on our testing dashboard and will be in 2.8.11. Thanks!
(0033979)
Robert Maynard (manager)
2013-10-07 10:03

 Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2013-02-27 18:42 Michael Tänzer New Issue
2013-02-27 18:50 Michael Tänzer Note Added: 0032404
2013-02-28 10:01 Clinton Stimpson Note Added: 0032410
2013-02-28 11:13 Brad King Note Added: 0032411
2013-02-28 11:14 Brad King Note Added: 0032412
2013-03-01 10:35 Michael Tänzer Note Added: 0032421
2013-03-01 10:45 Clinton Stimpson Note Added: 0032422
2013-03-01 10:54 Michael Tänzer Note Added: 0032423
2013-03-01 10:59 Clinton Stimpson Note Added: 0032424
2013-03-01 11:00 Michael Tänzer Note Added: 0032425
2013-03-01 11:50 Brad King Note Added: 0032427
2013-03-04 08:16 Brad King Note Added: 0032433
2013-03-04 08:16 Brad King Assigned To => Brad King
2013-03-04 08:16 Brad King Status new => resolved
2013-03-04 08:16 Brad King Resolution open => fixed
2013-03-04 08:16 Brad King Fixed in Version => CMake 2.8.11
2013-03-04 08:16 Brad King Target Version => CMake 2.8.11
2013-10-07 10:03 Robert Maynard Note Added: 0033979
2013-10-07 10:03 Robert Maynard Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team