View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013915BenderWeight Modulespublic2013-02-13 16:232013-04-02 14:28
ReporterJulien Finet 
Assigned Tojohan andruejol 
PrioritylowSeverityfeatureReproducibilityN/A
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version1.0 
Target Version1.0Fixed in Version1.0 
Summary0013915: Improve ArmatureWeight multi-threading
Descriptiona) Control how many threads are active at a time (make it a CLI advanced option: 0 = no limit, 1 = no multithread, 2 = no more than 2 threads...)

b) Use itkException to report execution error.
Optionally stop execution if one thread fails.

c) Check for "abort" if the user "Cancels" the execution

d) Report progress into Slicer GUI

e) Release memory as threads are done
TagsNo tags attached.
Attached Files

 Relationships
child of 0013873closedjohan andruejol Split the Armature Weight CLI in two. 

  Notes
(0032356)
johan andruejol (developer)
2013-02-20 09:19

 B) && C) && D)

http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=1a59d258b3cc0e64b34d044be9c6d363482de516 [^]

http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=5c46151607e192fe355aca8270b279c008c3c139 [^]

E)

http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=b699e185e8e040d52cc36d1f49f78f942f8739b5 [^]
(0032357)
Julien Finet (administrator)
2013-02-20 09:29
edited on: 2013-02-20 09:33

 Concerning 1a59d258b3cc0e64b34d044be9c6d363482de516, please refer to the following commit, the return type is wrong:
http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=1add1b92888cab7aadf18a18c844ef5aaa85cb31 [^]

Concerning 5c46151607e192fe355aca8270b279c008c3c139, I disagree. It is not the CLI responsibility to decide how it should be run (except if it CAN'T be run a specific way). It should be done at the application level
(0032360)
johan andruejol (developer)
2013-02-20 15:42

 In response to the concerns above, I fixed the return type and used the proper abort.

http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=fbbdfe32cef6c541ce9516adbbe6ec815de90526 [^]
(0032418)
Julien Finet (administrator)
2013-02-28 15:33

 Fixed in '13915-ImproveArmatureWeightMulti-threading' :
http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=5eab3568f3273975686c1067191f83d59cf3edae [^]

 Issue History
Date Modified Username Field Change
2013-02-13 16:23 Julien Finet New Issue
2013-02-13 16:23 Julien Finet Status new => assigned
2013-02-13 16:23 Julien Finet Assigned To => johan andruejol
2013-02-13 17:48 Julien Finet Description Updated
2013-02-14 10:48 Julien Finet Relationship added child of 0013873
2013-02-20 09:19 johan andruejol Note Added: 0032356
2013-02-20 09:29 Julien Finet Note Added: 0032357
2013-02-20 09:33 Julien Finet Note Edited: 0032357
2013-02-20 15:42 johan andruejol Note Added: 0032360
2013-02-28 15:33 Julien Finet Note Added: 0032418
2013-02-28 15:33 Julien Finet Status assigned => resolved
2013-02-28 15:33 Julien Finet Fixed in Version => 1.0
2013-02-28 15:33 Julien Finet Resolution open => fixed
2013-04-02 14:28 Julien Finet Target Version => 1.0

Copyright © 2000 - 2018 MantisBT Team