(0032059)
johan andruejol (developer)
2013-01-09 11:56
edited on: 2013-01-09 11:58

1) Capsule Source:
https://github.com/vovythevov/Bender/commit/a7caeb1fe691a3aea6d5258691152536ef0f4a1f [^]

2) Bone Envelope representation:
https://github.com/vovythevov/Bender/commit/2e996f75c968405800b282d9659a4176efab0e53 [^]

3) Envelope in Slicer:
https://github.com/vovythevov/Bender/commit/1f95ca8e7a13b9028c5a10aacdb503ada7d88e69 [^]

The envelopes are still very basic. I am not really sure they should go in the armature module since it is more related to the weights. So far I just added a On/Off checkbox but a slider for the radius should be helpful too.

(0032060)
Julien Finet (administrator)
2013-01-09 12:46

I think the armatures module is a great place. I can even think that envelopes be moved (in the future) in at line widget level as it is an all-purpose property (radius of interest of a line).
It is missing a radius spinbox to change the radius of the current bone.
You would also need to export the radius in the polydata generated by the armature widget (as a double type field data).

(0032086)
johan andruejol (developer)
2013-01-09 14:48

4) Naming constistency:
https://github.com/vovythevov/Bender/commit/1cde363161e5247461c7376e0381e7196235b628 [^]

5) Radius Spinbox:
https://github.com/vovythevov/Bender/commit/a61df61e79fd63db73ea8b146705e59054ee8175 [^]

6) Radius field data:
https://github.com/vovythevov/Bender/commit/811e884accd0ce3c841c0809331e18300959e704 [^]

(0032106)
johan andruejol (developer)
2013-01-15 17:27

It would be preferable for the radius to be adapted to each bone.
Ideally, the user would precise a ratio and the radius of the envelope would be computed with this ratio and the bone's length.

(0032107)
johan andruejol (developer)
2013-01-15 17:27

https://github.com/vovythevov/Bender/commit/65450e76937203e94c3777a41bff4adcbfa46869 [^]

(0032284)
Julien Finet (administrator)
2013-02-14 11:15

7) ++ Envelope GUI (Envelope opacity + Envelope ratio for all the bones (+ Envelope on/off checkbox)) should go in the Armature section.
Envelope in Bone section should control the "ratio" of the selected bone

8) - Envelopes should be semi-transparent by default. Envelopes colors should be the same as the bone, but very desaturated (e.g. S=10%) and close to white (e.g. V=90%), H stays the same.

9) = If the envelope opacity is transparent, the envelope should have its front faces culled.

10) -- In XRay mode, envelopes should be rendered in a first pass. the the bones are rendered.

(0032306)
johan andruejol (developer)
2013-02-16 00:25

7)
http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=ed9ceb06fb632c53ab8fbe56a1c026a9b786218c [^]

8) (Semi-transparency only)
http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=e2e58eddd6a2502e5c7a28debdaee799f874389a [^]

9)http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=4d3a35815cdabf5ab693e1cc5a4b8e561f8feb72 [^]

(0032394)
johan andruejol (developer)
2013-02-27 08:54

10) No envelope display in pose mode:

http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=baf63d6bd9ee20294dae2ef3feeb48d3ead98e95 [^]

11) Move Envelopes in the Armature category:

http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=7dfa8ae4bae660c4dfd52573068abe8f2628917d [^]

Issue History
Date Modified	Username	Field	Change
2012-11-12 16:49	Julien Finet	New Issue
2012-11-12 16:49	Julien Finet	Status	new => assigned
2012-11-12 16:49	Julien Finet	Assigned To	=> johan andruejol
2012-11-12 16:49	Julien Finet	Relationship added	child of 0013672
2013-01-09 11:56	johan andruejol	Note Added: 0032059
2013-01-09 11:58	johan andruejol	Note Edited: 0032059
2013-01-09 12:46	Julien Finet	Note Added: 0032060
2013-01-09 14:48	johan andruejol	Note Added: 0032086
2013-01-10 10:08	johan andruejol	Status	assigned => resolved
2013-01-10 10:08	johan andruejol	Resolution	open => fixed
2013-01-15 17:25	johan andruejol	Status	resolved => feedback
2013-01-15 17:25	johan andruejol	Resolution	fixed => reopened
2013-01-15 17:27	johan andruejol	Note Added: 0032106
2013-01-15 17:27	johan andruejol	Note Added: 0032107
2013-01-15 17:28	johan andruejol	Status	feedback => resolved
2013-01-15 17:28	johan andruejol	Resolution	reopened => fixed
2013-02-14 10:57	Julien Finet	Relationship added	related to 0013873
2013-02-14 11:15	Julien Finet	Note Added: 0032284
2013-02-14 11:15	Julien Finet	Status	resolved => assigned
2013-02-14 11:20	Julien Finet	Resolution	fixed => reopened
2013-02-14 11:20	Julien Finet	Product Version	=> 0.1
2013-02-14 11:20	Julien Finet	Summary	Add enveloppe representation around bones => Add envelope representation around bones
2013-02-15 14:59	Julien Finet	Priority	normal => high
2013-02-16 00:25	johan andruejol	Note Added: 0032306
2013-02-18 10:13	johan andruejol	Priority	high => normal
2013-02-27 08:54	johan andruejol	Note Added: 0032394
2013-03-04 10:22	johan andruejol	Status	assigned => resolved
2013-03-04 10:22	johan andruejol	Resolution	reopened => fixed
2013-03-04 11:36	Julien Finet	Status	resolved => closed
2013-03-04 11:36	Julien Finet	Fixed in Version	=> 1.0
2013-04-02 14:28	Julien Finet	Target Version	=> 1.0

Notes
(0032059) johan andruejol (developer) 2013-01-09 11:56 edited on: 2013-01-09 11:58	1) Capsule Source: https://github.com/vovythevov/Bender/commit/a7caeb1fe691a3aea6d5258691152536ef0f4a1f [^] 2) Bone Envelope representation: https://github.com/vovythevov/Bender/commit/2e996f75c968405800b282d9659a4176efab0e53 [^] 3) Envelope in Slicer: https://github.com/vovythevov/Bender/commit/1f95ca8e7a13b9028c5a10aacdb503ada7d88e69 [^] The envelopes are still very basic. I am not really sure they should go in the armature module since it is more related to the weights. So far I just added a On/Off checkbox but a slider for the radius should be helpful too.

(0032060) Julien Finet (administrator) 2013-01-09 12:46	I think the armatures module is a great place. I can even think that envelopes be moved (in the future) in at line widget level as it is an all-purpose property (radius of interest of a line). It is missing a radius spinbox to change the radius of the current bone. You would also need to export the radius in the polydata generated by the armature widget (as a double type field data).

(0032086) johan andruejol (developer) 2013-01-09 14:48	4) Naming constistency: https://github.com/vovythevov/Bender/commit/1cde363161e5247461c7376e0381e7196235b628 [^] 5) Radius Spinbox: https://github.com/vovythevov/Bender/commit/a61df61e79fd63db73ea8b146705e59054ee8175 [^] 6) Radius field data: https://github.com/vovythevov/Bender/commit/811e884accd0ce3c841c0809331e18300959e704 [^]

(0032106) johan andruejol (developer) 2013-01-15 17:27	It would be preferable for the radius to be adapted to each bone. Ideally, the user would precise a ratio and the radius of the envelope would be computed with this ratio and the bone's length.

(0032107) johan andruejol (developer) 2013-01-15 17:27	https://github.com/vovythevov/Bender/commit/65450e76937203e94c3777a41bff4adcbfa46869 [^]

(0032284) Julien Finet (administrator) 2013-02-14 11:15	7) ++ Envelope GUI (Envelope opacity + Envelope ratio for all the bones (+ Envelope on/off checkbox)) should go in the Armature section. Envelope in Bone section should control the "ratio" of the selected bone 8) - Envelopes should be semi-transparent by default. Envelopes colors should be the same as the bone, but very desaturated (e.g. S=10%) and close to white (e.g. V=90%), H stays the same. 9) = If the envelope opacity is transparent, the envelope should have its front faces culled. 10) -- In XRay mode, envelopes should be rendered in a first pass. the the bones are rendered.

(0032306) johan andruejol (developer) 2013-02-16 00:25	7) http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=ed9ceb06fb632c53ab8fbe56a1c026a9b786218c [^] 8) (Semi-transparency only) http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=e2e58eddd6a2502e5c7a28debdaee799f874389a [^] 9)http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=4d3a35815cdabf5ab693e1cc5a4b8e561f8feb72 [^]

(0032394) johan andruejol (developer) 2013-02-27 08:54	10) No envelope display in pose mode: http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=baf63d6bd9ee20294dae2ef3feeb48d3ead98e95 [^] 11) Move Envelopes in the Armature category: http://public.kitware.com/gitweb?p=Bender/Bender.git;a=commit;h=7dfa8ae4bae660c4dfd52573068abe8f2628917d [^]