View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013646CMakeCMakepublic2012-11-02 17:372012-11-09 18:17
ReporterDominik Schmidt 
Assigned ToAlex Neundorf 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSLinuxOS Version
Product VersionCMake 2.8.10 
Target VersionFixed in Version 
Summary0013646: Automoc doesn't recognise "#if QT_VERSION = x" anymore
DescriptionWith the latest release of CMake compilation of Tomahawk Player stopped working for us because automoc stopped producing output for a certain file.

Obviously code ifdef'ed by "#if QT_VERSION >= 0x040400" isn't scanned anymore.

The commit that fixed building for us:
https://github.com/tomahawk-player/tomahawk/commit/c910e1b58f01a42b9f99222e501172576d8cad06 [^]
Steps To ReproducePut code in "#if QT_VERSION >= 0x040400" and run automoc on it.
Additional InformationOf course I'm talking about CMake built in automoc, not automoc4 from KDE.
TagsNo tags attached.
Attached Files

 Relationships
related to 0013667closedAlex Neundorf Automoc fails to handle Q_INTERFACES 

  Notes
(0031403)
Alex Neundorf (developer)
2012-11-03 14:05

Can you please try to create a small testcase ?
I tried to reproduce it here by simply inserting the #if and it still built, both with 2.8.9 and 2.8.10.
(0031475)
Alex Neundorf (developer)
2012-11-06 14:14

I tried to build tomahawk, but a bunch of required libraries is missing on my system.
So, can you please try to create a small testcase, consisting of only a few files ?

Thanks
Alex
(0031517)
Alex Neundorf (developer)
2012-11-09 18:17

Fixed.
 This is in the FixAutomocRegression branch on cmake stage:
 http://cmake.org/gitweb?p=stage/cmake.git [^] [^]
 
 http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=a9465098c01ace9ead62c04674dc2f4a529962f5 [^] [^]
 
 Please give it a try and reopen the bug report if it still doesn't work for you.
 

 Issue History
Date Modified Username Field Change
2012-11-02 17:37 Dominik Schmidt New Issue
2012-11-03 06:57 Alex Neundorf Assigned To => Alex Neundorf
2012-11-03 06:57 Alex Neundorf Status new => assigned
2012-11-03 14:05 Alex Neundorf Note Added: 0031403
2012-11-06 14:14 Alex Neundorf Note Added: 0031475
2012-11-09 18:16 Alex Neundorf Relationship added related to 0013667
2012-11-09 18:17 Alex Neundorf Note Added: 0031517
2012-11-09 18:17 Alex Neundorf Severity minor => major
2012-11-09 18:17 Alex Neundorf Status assigned => closed
2012-11-09 18:17 Alex Neundorf Resolution open => fixed


Copyright © 2000 - 2018 MantisBT Team