View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013604CMakeCCMakepublic2012-10-24 13:442013-04-17 08:54
Reportermwoehlke 
Assigned ToDavid Cole 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
Platformx86_64OSFedoraOS Version17
Product VersionCMake 2.8.9 
Target VersionCMake 2.8.11Fixed in VersionCMake 2.8.11 
Summary0013604: wrong behavior editing field in column 0
DescriptionEditing a field behaves differently when the cursor is in column 0 versus any other column. DEL does not work at all. Any other key erases the existing value. In other columns, DEL works, and typing inserts text, as expected.
TagsNo tags attached.
Attached Filespatch file icon 0001-ccmake-allow-DEL-in-first-column.patch [^] (1,021 bytes) 2012-10-24 15:05 [Show Content]

 Relationships

  Notes
(0031305)
mwoehlke (developer)
2012-10-24 13:45

First issue (DEL doesn't work) is fixed by the following patch:

diff --git a/Source/CursesDialog/cmCursesStringWidget.cxx b/Source/CursesDialog/cmCursesStringWidget.cxx
index 5c7414f..bd1ff71 100644
--- a/Source/CursesDialog/cmCursesStringWidget.cxx
+++ b/Source/CursesDialog/cmCursesStringWidget.cxx
@@ -175,7 +175,7 @@ bool cmCursesStringWidget::HandleInput(int& key, cmCursesMainForm* fm,
       }
     else if ( key == ctrl('d') ||key == KEY_DC )
       {
- if ( form->curcol > 0 )
+ if ( form->curcol >= 0 )
         {
         form_driver(form, REQ_DEL_CHAR);
         }


Didn't immediately see what would cause the second (text is erased)
(0031308)
David Cole (manager)
2012-10-24 15:17

I've pushed a fix for this issue to the CMake stage repo in the topic branch "fix-13604-ccmake-del-key"

As soon as 2.8.10 is final, I'll merge it to 'next' for dashboard testing, and then after that, it will get merged to 'master' and be available as soon as we start building the 2.8.11 release.

Thanks for the bug report! (And the patch!)
(0031380)
David Cole (manager)
2012-11-01 17:58

Fix pushed to 'next':

  http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9998321 [^]

You can use a nightly build of CMake if you need the fix before the 2.8.11 release.
(0032860)
Robert Maynard (manager)
2013-04-17 08:54

Closing resolved issues that have not been updated in more than 4 months.

 Issue History
Date Modified Username Field Change
2012-10-24 13:44 mwoehlke New Issue
2012-10-24 13:45 mwoehlke Note Added: 0031305
2012-10-24 14:44 David Cole Assigned To => David Cole
2012-10-24 14:44 David Cole Status new => assigned
2012-10-24 14:44 David Cole Target Version => CMake 2.8.11
2012-10-24 15:05 mwoehlke File Added: 0001-ccmake-allow-DEL-in-first-column.patch
2012-10-24 15:17 David Cole Note Added: 0031308
2012-11-01 17:58 David Cole Note Added: 0031380
2012-11-01 17:58 David Cole Status assigned => resolved
2012-11-01 17:58 David Cole Fixed in Version => CMake 2.8.11
2012-11-01 17:58 David Cole Resolution open => fixed
2013-04-17 08:54 Robert Maynard Note Added: 0032860
2013-04-17 08:54 Robert Maynard Status resolved => closed


Copyright © 2000 - 2018 MantisBT Team