| View Issue Details [ Jump to Notes ] | [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0013455 | CMake | CPack | public | 2012-08-03 23:24 | 2013-03-04 08:38 |
|
| Reporter | szx | |
| Assigned To | David Cole | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | CMake 2.8.8 | |
| Target Version | CMake 2.8.10 | Fixed in Version | CMake 2.8.10 | |
|
| Summary | 0013455: CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL is broken |
| Description | I stumbled upon this issue:
http://public.kitware.com/Bug/view.php?id=9946 [^]
and was quite happy until I found that it doesn't work for me...
It seems that you have to use CPACK_NSIS_PACKAGE_NAME in Modules/NSIS.template.in instead of CPACK_PACKAGE_NAME to get this feature working because in registry the package name looks like "PackageName x.y", not just "PackageName".
|
| Tags | NSIS |
|
| Attached Files |  fix-nsis-enable-uninstall-before-install.patch [^] (666 bytes) 2012-08-03 23:24 [Show Content] [Hide Content] Modules/NSIS.template.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Modules/NSIS.template.in b/Modules/NSIS.template.in
index 43f72f6..f96017d 100644
--- a/Modules/NSIS.template.in
+++ b/Modules/NSIS.template.in
@@ -902,7 +902,7 @@ SectionEnd
Function .onInit
StrCmp "@CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL@" "ON" 0 inst
- ReadRegStr $0 HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\@CPACK_PACKAGE_NAME@" "UninstallString"
+ ReadRegStr $0 HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\@CPACK_NSIS_PACKAGE_NAME@" "UninstallString"
StrCmp $0 "" inst
MessageBox MB_YESNOCANCEL|MB_ICONEXCLAMATION \
|
|