View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0013239

CMake

public

2012-05-21 11:09

2012-10-01 13:23

Reporter

C.M.

Assigned To

Brad King

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

All platforms

All OS

OS Version

All

Product Version

CMake 2.8.8

Target Version

CMake 2.8.9

Fixed in Version

CMake 2.8.9

Summary

0013239: Not all Fortran dependencies are recognized.

Description

Pre-processor dependencies in FORTRAN using include files are not recognized
if specified as
#include <...>
which (at least for several Fortran preprocessors is a valid syntax), e.g.
http://www2.fz-juelich.de/jsc/docs/vendordocs/NAGWare_f95 [^]
/html/fpp.html#INCEXTERNAL

Steps To Reproduce

Generate any Fortran file and insert an include statement
#include <file>
into it. Check the "*.depend" files. The include file is not listed.
Using
#include "file"
does however list the dependency correctly.

Additional Information

Reason for this behavior is the flex rule in cmDependsFortranLexer.in.l
line 73-90 and 111 which allows strings only as "" or ''. Adding here
a third string rule for <...> does quick fix the problem. However, one probably
should create a new string type and add/change the CPP_INCLUDE parser rule
in cmDependsFortranParser.y as well to not allow all strings to be <>.

Tags

No tags attached.

Attached Files

Relationships

Notes
(0029545) Brad King (manager) 2012-05-22 14:16	Good catch. I think that came from makedepf90: http://cmake.org/gitweb?p=cmake.git;a=blob;f=Source/cmDependsFortranLexer.in.l;hb=v2.8.8#l13 [^] This should fix it: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ad210790 [^] Adding a test for this will require construction of a test like the BuildDepends test but for Fortran. Unfortunately I do not have time to do that now.

(0031133) David Cole (manager) 2012-10-01 13:23	Closing resolved issues that have not been updated in more than 4 months.

Issue History
Date Modified	Username	Field	Change
2012-05-21 11:09	C.M.	New Issue
2012-05-22 14:16	Brad King	Note Added: 0029545
2012-05-22 14:16	Brad King	Assigned To	=> Brad King
2012-05-22 14:16	Brad King	Status	new => resolved
2012-05-22 14:16	Brad King	Resolution	open => fixed
2012-05-22 14:16	Brad King	Fixed in Version	=> CMake 2.8.9
2012-05-22 14:16	Brad King	Target Version	=> CMake 2.8.9
2012-10-01 13:23	David Cole	Note Added: 0031133
2012-10-01 13:23	David Cole	Status	resolved => closed