View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0012951CMakeCMakepublic2012-02-09 11:472016-06-10 14:31
ReporterAmine Khaldi 
Assigned ToKitware Robot 
PlatformOSOS Version
Product VersionCMake 2.8.7 
Target VersionCMake 2.8.12Fixed in Version 
Summary0012951: Assembly preprocessor definition support in VS IDE generators
DescriptionWe (ReactOS) set CMAKE_ASM_COMPILE_OBJECT and use <FLAGS>, <DEFINES>, <OBJECT>...etc. The <DEFINES> expands like the rest of those variables when the nmake files generator is used, but doesn't expand when you use the VS generators. This is blocking us from using them because many of our core components contain asm files as source files.
TagsNo tags attached.
Attached Files


Brad King (manager)
2012-02-09 13:45

Variables like CMAKE_ASM_COMPILE_OBJECT are used only by the Makefile generators. The VS generators just put the sources in the IDE project file and ask VS to build the project. The VS generators know how to put preprocessor definitions in place.

However, assembly support is immature compared to C and C++ support in general.
Amine Khaldi (reporter)
2012-02-09 13:57

I see.
Is it possible then to fix the VS generators so that a simple add_library(foo.c bar.s) could lead to having two objects linked instead of just the C one ? Right now the generated VS solution silently ignores all asm source files. As a result we're missing out on many nifty things that require VS projects.

Thank you for the prompt reply.
Brad King (manager)
2012-02-09 14:29

I'm not sure the current state of VS support for assembly in our generators and I've not worked with assembly in the VS IDE projects myself.

We've not had time/drive/need/resources to implement first-class assembly support in the VS generators. Assembly support has been a user-contributed and user-maintained feature for the most part so far. We are happy to review patches :)
David Cole (manager)
2012-08-11 21:09

Sending old, never assigned issues to the backlog.

(The age of the bug, plus the fact that it's never been assigned to anyone means that nobody is actively working on it...)

If an issue you care about is sent to the backlog when you feel it should have been addressed in a different manner, please bring it up on the CMake mailing list for discussion. Sign up for the mailing list here, if you're not already on it: [^]

It's easy to re-activate a bug here if you can find a CMake developer who has the bandwidth to take it on, and ferry a fix through to our 'next' branch for dashboard testing.
David Cole (manager)
2012-10-18 11:17

These bugs were deferred from target version 2.8.10 to 2.8.11 based on the responses to this email thread on the CMake developer's mailing list: [^]
Kitware Robot (administrator)
2016-06-10 14:28

Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page.

 Issue History
Date Modified Username Field Change
2012-02-09 11:47 Amine Khaldi New Issue
2012-02-09 13:45 Brad King Note Added: 0028546
2012-02-09 13:57 Amine Khaldi Note Added: 0028547
2012-02-09 14:29 Brad King Note Added: 0028549
2012-08-11 21:09 David Cole Status new => backlog
2012-08-11 21:09 David Cole Note Added: 0030364
2012-08-20 11:52 David Cole Status backlog => new
2012-08-20 11:52 David Cole Target Version => CMake 2.8.10
2012-10-18 11:16 David Cole Target Version CMake 2.8.10 => CMake 2.8.11
2012-10-18 11:17 David Cole Note Added: 0031266
2012-10-18 11:23 Brad King Summary The DEFINE variable doesn't expand with VS generators but expands correctly with the nmake one => Assembly preprocessor definition support in VS IDE generators
2013-05-17 09:33 Robert Maynard Target Version CMake 2.8.11 => CMake 2.8.12
2016-06-10 14:28 Kitware Robot Note Added: 0041983
2016-06-10 14:28 Kitware Robot Status new => resolved
2016-06-10 14:28 Kitware Robot Resolution open => moved
2016-06-10 14:28 Kitware Robot Assigned To => Kitware Robot
2016-06-10 14:31 Kitware Robot Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team