View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0012283 | CMake | CMake | public | 2011-06-16 15:07 | 2012-02-06 06:07 | ||||
Reporter | Jérôme Gardou | ||||||||
Assigned To | Brad King | ||||||||
Priority | normal | Severity | tweak | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | MinGW | OS | Windows | OS Version | all | ||||
Product Version | CMake 2.8.4 | ||||||||
Target Version | CMake 2.8.6 | Fixed in Version | CMake 2.8.6 | ||||||
Summary | 0012283: Cmake -E echo kills performance of MinGW Makefiles | ||||||||
Description | Instead of '@echo some text', MinGW Makefiles generator use '@cmake -E echo "some text"' Quoting cmake source code comment : // mingw32-make has trouble running code like // // @echo message with spaces // // If quotes are added // // @echo "message with spaces" // // it runs but the quotes are displayed. Instead just use cmake to // echo. which I am unable to confirm. Maybe an old version of mingw32-make? Furthermore, using @echo avoids garbage output in case of a parallel build Please find patch attached :-) | ||||||||
Steps To Reproduce | Just trigger a mingw32-make help into the build directory of a library, and benchmark it with/without the patch. I can see the difference even with a medium sized library. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | 0004-MinGW-Makefile-Generator-use-native-echo-command.patch [^] (1,171 bytes) 2011-06-16 15:07 [Show Content] | ||||||||
Relationships | ||||||
|
Relationships |
Notes | |
(0026882) Brad King (manager) 2011-06-16 15:27 |
Some history: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7e92f0b4 [^] http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=69356d8a [^] The mingw32-make behavior persists even today. It is actually a Windows shell behavior. > type foo.make all: @echo "tada" > mingw32-make -f foo.make "tada" > mingw32-make --version GNU Make 3.82 Built for i386-pc-mingw32 Copyright (C) 2010 Free Software Foundation, Inc. |
(0026883) Brad King (manager) 2011-06-16 15:30 |
While the quoting behavior persists I do not see the echo-with-spaces-but-no-quotes behavior anymore. |
(0026884) Jérôme Gardou (reporter) 2011-06-16 15:36 |
I don't question the remark about the quotes, but I don't experience any problem with something like : @echo pim pam poum |
(0026885) Brad King (manager) 2011-06-16 15:57 |
On my machine all CMake's tests pass using native echo and modern mingw32-make. Since this was the only use of the "NativeEcho" infrastructure I removed all of it: http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6b4d3ad3 [^] If only I wrote better commit messages back when the original change was made perhaps we would know more about the original problem. |
(0027391) Brad King (manager) 2011-09-07 09:55 |
CMake 2.8.6-rc* contain the fix linked in 0012283:0026885. |
(0028496) David Cole (manager) 2012-02-06 06:07 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2011-06-16 15:07 | Jérôme Gardou | New Issue | |
2011-06-16 15:07 | Jérôme Gardou | File Added: 0004-MinGW-Makefile-Generator-use-native-echo-command.patch | |
2011-06-16 15:27 | Brad King | Note Added: 0026882 | |
2011-06-16 15:27 | Brad King | Status | new => backlog |
2011-06-16 15:30 | Brad King | Note Added: 0026883 | |
2011-06-16 15:36 | Jérôme Gardou | Note Added: 0026884 | |
2011-06-16 15:55 | Brad King | Assigned To | => Brad King |
2011-06-16 15:55 | Brad King | Status | backlog => assigned |
2011-06-16 15:57 | Brad King | Note Added: 0026885 | |
2011-06-16 15:58 | Brad King | Relationship added | related to 0011304 |
2011-09-07 09:55 | Brad King | Note Added: 0027391 | |
2011-09-07 09:55 | Brad King | Status | assigned => resolved |
2011-09-07 09:55 | Brad King | Resolution | open => fixed |
2011-09-07 09:55 | Brad King | Fixed in Version | => CMake 2.8.6 |
2011-09-07 09:55 | Brad King | Target Version | => CMake 2.8.6 |
2012-02-06 06:07 | David Cole | Note Added: 0028496 | |
2012-02-06 06:07 | David Cole | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |