View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0010701CMakeCPackpublic2010-05-11 04:142011-07-08 17:54
ReporterEric NOULARD 
Assigned ToEric NOULARD 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionCMake-2-8 
Target VersionCMake 2.8.3Fixed in VersionCMake 2.8.3 
Summary0010701: Lack of "%doc, %config, Obsolete" in CPackRPM
DescriptionThis is a reminder for a patch proposal sent on the ML:
http://www.cmake.org/pipermail/cmake/2010-May/036841.html [^]

Basically some missing features are wanted:
 * Lack of support for file names containing spaces
 * Lack of support for %config and %config(noreplace)
 * Lack of support for "Obsoletes:"
 * Lack of support for %doc

TagsNo tags attached.
Attached Filesdiff file icon bug10701-ErwanLegrand-CPackRPM.cmake.diff [^] (4,598 bytes) 2010-05-11 04:17 [Show Content]

 Relationships
related to 0010294closedEric NOULARD Patch for CPack RPM generator (CPACK_RPM_SPEC_IGNORE_FILES) 
related to 0010345closedEric NOULARD [Patch] CPackRPM: file path with spaces 
related to 0010741closedEric NOULARD Some enhancements to the RPM generator [PATCH] 
related to 0007000closedEric NOULARD CPack RPM generator should always "CPACK_SET_DESTDIR" 
related to 0010935closedEric NOULARD Lack of support for relocatable package 
related to 0009932closedEric NOULARD RPM Generator, spaces in CPACK_PACKAGE_NAME cause error while creating RPM archive 
related to 0010871closedEric NOULARD CPackRPM-generated spec file won't accept spaces in file paths. 

  Notes
(0020707)
Eric NOULARD (developer)
2010-05-11 04:18

Attached proposed patch,
Added relationship with other bugs
(0020710)
J. Bedouet (reporter)
2010-05-11 12:28
edited on: 2010-05-11 12:33

I would like to add an other missing feature:
 * Lack of support for relocatable package

To make a relocatable package, you have to add a tag "Prefix: " whose the value is generally the CMake prefix.


If I mimic the Buildarch tag, it would be something like that

# CPACK_RPM_PACKAGE_PREFIX (optional)
IF(CPACK_RPM_PACKAGE_PREFIX)
  SET(TMP_RPM_PREFIX "Prefix: ${CPACK_RPM_PACKAGE_PREFIX}")
  IF(CPACK_RPM_PACKAGE_DEBUG)
    MESSAGE("CPackRPM:Debug: using user-specified prefix (for relocatable package) = ${CPACK_RPM_PACKAGE_PREFIX}")
  ENDIF(CPACK_RPM_PACKAGE_DEBUG)
ELSE(CPACK_RPM_PACKAGE_PREFIX)
  SET(TMP_RPM_BUILDARCH "")
ENDIF(CPACK_RPM_PACKAGE_PREFIX)


and adding \@TMP_RPM_PREFIX\@ after \@TMP_RPM_BUILDARCH\@ in the specfile template.

It's not tested but it's very similar to Buildarch tag.

For more specific information, see Maximum RPM (http://www.rpm.org/max-rpm/ch-rpm-reloc.html [^] ).


Please, tell me if I must create a new issue but it's very similar to this one. Thanks.

(0021223)
Eric NOULARD (developer)
2010-07-04 07:09

bug 10741 did fix the support for Obsoletes
(0021227)
Eric NOULARD (developer)
2010-07-04 09:16

The space in filename issue has been merged to next.

commit 53899460dfb1aef50ad3bb7acd1ec30d618cc5e7
Merge: 5858e6d 6926e91
Author: Eric NOULARD <eric.noulard@gmail.com>
Date: Sun Jul 4 15:10:18 2010 +0200

    Merge branch 'CPackRPM-handleFileWithSpace' into next

commit 6926e9114c832607bdad97827bb918cb21ab231d
Author: Eric NOULARD <eric.noulard@gmail.com>
Date: Sun Jul 4 14:05:25 2010 +0200

    CPackRPM:: Quote every filenames in %file section (see bugs 10701,10871,10345)
(0021230)
Eric NOULARD (developer)
2010-07-04 10:54

Concerning the %config and %config(noreplace)
there is a neat interaction with the DESTDIR handling and absolute path name...
I'm afraid that the issue of DESTDIR and absolute path name should be handled
first and then I'll try to cope with %config...

Added relation with bug 7000 which is the one to be solved in the first place.
(my opinion)
(0021231)
Eric NOULARD (developer)
2010-07-04 11:08

I did create a separate 10935 bug in order to handle the relocatable
feature request separately
(0023219)
Eric NOULARD (developer)
2010-11-12 14:16

A small part of this bug remains which is the (noreplace) handling
this will be done in bug 0010294
http://public.kitware.com/Bug/view.php?id=10294 [^]

 Issue History
Date Modified Username Field Change
2010-05-11 04:14 Eric NOULARD New Issue
2010-05-11 04:16 Eric NOULARD Relationship added related to 0010294
2010-05-11 04:17 Eric NOULARD Relationship added related to 0010345
2010-05-11 04:17 Eric NOULARD File Added: bug10701-ErwanLegrand-CPackRPM.cmake.diff
2010-05-11 04:18 Eric NOULARD Note Added: 0020707
2010-05-11 04:22 Eric NOULARD Status new => assigned
2010-05-11 04:22 Eric NOULARD Assigned To => Eric NOULARD
2010-05-11 12:28 J. Bedouet Note Added: 0020710
2010-05-11 12:29 J. Bedouet Note Edited: 0020710
2010-05-11 12:30 J. Bedouet Note Edited: 0020710
2010-05-11 12:33 J. Bedouet Note Edited: 0020710
2010-07-04 07:09 Eric NOULARD Relationship added related to 0010741
2010-07-04 07:09 Eric NOULARD Note Added: 0021223
2010-07-04 09:14 Eric NOULARD Relationship added related to 0009932
2010-07-04 09:14 Eric NOULARD Relationship added related to 0010871
2010-07-04 09:16 Eric NOULARD Note Added: 0021227
2010-07-04 10:52 Eric NOULARD Relationship added related to 0007000
2010-07-04 10:54 Eric NOULARD Note Added: 0021230
2010-07-04 11:08 Eric NOULARD Relationship added related to 0010935
2010-07-04 11:08 Eric NOULARD Note Added: 0021231
2010-11-12 14:16 Eric NOULARD Note Added: 0023219
2010-11-12 14:16 Eric NOULARD Status assigned => resolved
2010-11-12 14:16 Eric NOULARD Fixed in Version => CMake 2.8.3
2010-11-12 14:16 Eric NOULARD Resolution open => fixed
2010-11-12 14:16 Eric NOULARD Status resolved => closed
2011-07-08 17:54 David Cole Target Version => CMake 2.8.3


Copyright © 2000 - 2018 MantisBT Team