| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0010257 | CMake | CMake | public | 2010-02-08 14:59 | 2016-01-21 17:29 | ||||
| Reporter | Kerry Bonin | ||||||||
| Assigned To | Bill Hoffman | ||||||||
| Priority | normal | Severity | block | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | CMake-2-8 | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0010257: Installer erasing windows PATH | ||||||||
| Description | I've had two developers who just installed cmake-2.8.0-win32-x86.exe report (and show me) that installing (on XP SP2) w/ 'all users' and 'add to system path' selected resulted in their windows PATH environment variable ending up containing ONLY the cmake path - the previous path contents are missing. If this isn't a fluke of our corporate install environment (I haven't tried recreating in clean VM, as I don't have one setup ATM...) I'd recommend a fast fix and release spin, as this (obviously) breaks windows machines... | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files |  cmake-eaten-path.txt [^] (1,478 bytes) 2010-02-09 11:26 [Show Content]
| ||||||||
| Relationships | ||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||
| Relationships |
| Notes | |
|
(0019481) Bill Hoffman (manager) 2010-02-08 15:37 |
We have had reports of this, but have NEVER been able to duplicate it... It just does not seem to happen to us. I am sort of at a loss of how to fix it if I can not reproduce it. Can you give me the full PATH before CMake kills it? |
|
(0019483) Kerry Bonin (reporter) 2010-02-08 15:54 |
I have ONE of the paths that was erased (by a fluke, the developer had it onscreen in a DOS window). That said, I'd rather not publish the path of a corporate machine on a public mailing list (due to near but not completely zero security issue) - if you send a private email to my gmail account (kerrybonin@gmail.com), I'll reply with the path... |
|
(0019485) Kerry Bonin (reporter) 2010-02-08 16:18 |
The developer has sent me her paths (all users and user), just waiting for an email to send them to now... |
|
(0019487) Bill Hoffman (manager) 2010-02-08 17:29 |
Attach it to this bug with the upload file button. |
|
(0019496) Kerry Bonin (reporter) 2010-02-09 11:29 |
I've attached the file - some information related to corporate environment redacted, alphas replaced w/ 'x', all other syntax preserved. This should allow an attempt at reproducing just about any issue related to syntax and parsing. I'd also be happy to test any fixes on a machine that previously had its path reliably eaten, please let me know... |
|
(0019497) Bill Hoffman (manager) 2010-02-09 14:10 |
OK, I have reproduced and found a fix of sorts. $ cvs commit -m "Fix for bug 0010257, NSIS could remove a PATH if it was too long" NSIS.template.in Committer: Bill Hoffman <bill.hoffman@kitware.com> /cvsroot/CMake/CMake/Modules/NSIS.template.in,v <-- NSIS.template.in new revision: 1.42; previous revision: 1.41 It will now warn if the PATH is long and NOT modify the PATH at all in this case. |
|
(0019498) Bill Hoffman (manager) 2010-02-09 14:10 |
I will put this fix into the next RC for CMake 2.8.1 |
|
(0019499) Kerry Bonin (reporter) 2010-02-09 14:32 edited on: 2010-02-09 14:48 |
I read up some on this issue, which apparently has been in NSIS for some time - the default build of NSIS has a string length of 1024 bytes, which results in broken paths. They also have a "special build" of NSIS that increases this global string limit to 8k bytes. For some reason (I can't find) this "feature" hasn't been turned on in their trunk. I would like to request that cmake be packaged with this "special build" http://nsis.sourceforge.net/Special_Builds [^] to remove this bug. This is an optional build of their trunk, called 'strlen_8192', which I believe just defines a preprocessor macro NSIS_MAX_STRLEN=8192. |
|
(0019502) Bill Hoffman (manager) 2010-02-09 15:50 |
I will look into that. The fix that I did should work in that case as well. If you go over 8192 it will warn and do thing. I don't want to depend on this, and I want to make sure CMake never kills the path again. |
|
(0022290) David Cole (manager) 2010-09-21 11:51 |
Is this still a problem with 2.8.2 and the 2.8.3-rc1 release candidate? Can we mark this as fixed, or is there still an issue here? |
|
(0022864) David Cole (manager) 2010-11-04 17:04 |
This was fixed in an earlier release of CMake (not sure if it was 2.8.1 or 2.8.2 or 2.8.3) -- if it rears its ugly head again, then please re-open and elaborate... |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2010-02-08 14:59 | Kerry Bonin | New Issue | |
| 2010-02-08 15:37 | Bill Hoffman | Note Added: 0019481 | |
| 2010-02-08 15:38 | Bill Hoffman | Status | new => assigned |
| 2010-02-08 15:38 | Bill Hoffman | Assigned To | => Bill Hoffman |
| 2010-02-08 15:54 | Kerry Bonin | Note Added: 0019483 | |
| 2010-02-08 16:18 | Kerry Bonin | Note Added: 0019485 | |
| 2010-02-08 17:29 | Bill Hoffman | Note Added: 0019487 | |
| 2010-02-09 11:26 | Kerry Bonin | File Added: cmake-eaten-path.txt | |
| 2010-02-09 11:29 | Kerry Bonin | Note Added: 0019496 | |
| 2010-02-09 13:54 | Bill Hoffman | Relationship added | has duplicate 0010063 |
| 2010-02-09 13:55 | Bill Hoffman | Relationship added | has duplicate 0009878 |
| 2010-02-09 13:56 | Bill Hoffman | Relationship added | duplicate of 0010169 |
| 2010-02-09 14:10 | Bill Hoffman | Note Added: 0019497 | |
| 2010-02-09 14:10 | Bill Hoffman | Note Added: 0019498 | |
| 2010-02-09 14:32 | Kerry Bonin | Note Added: 0019499 | |
| 2010-02-09 14:48 | Kerry Bonin | Note Edited: 0019499 | |
| 2010-02-09 15:50 | Bill Hoffman | Note Added: 0019502 | |
| 2010-02-12 15:25 | Bill Hoffman | Relationship added | has duplicate 0010282 |
| 2010-03-03 11:50 | Bill Hoffman | Relationship added | has duplicate 0010359 |
| 2010-09-21 11:51 | David Cole | Note Added: 0022290 | |
| 2010-11-04 17:04 | David Cole | Note Added: 0022864 | |
| 2010-11-04 17:04 | David Cole | Status | assigned => closed |
| 2010-11-04 17:04 | David Cole | Resolution | open => fixed |
| 2011-03-17 13:44 | David Cole | Relationship added | has duplicate 0011931 |
| 2012-01-15 22:28 | David Cole | Relationship added | related to 0012875 |
| 2014-02-03 16:05 | Brad King | Relationship added | related to 0014716 |
| 2015-06-29 13:19 | David Cole | Relationship added | related to 0015635 |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |