MantisBT - CMake
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0011706CMake(No Category)public2011-01-16 06:032012-02-06 06:07
ReporterAndreas Schneider. 
Assigned ToKovarththanan Rajaratnam 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionCMake 2.8.6Fixed in VersionCMake 2.8.6 
Summary0011706: Improved version of FindZLIB
DescriptionThis is an improved version of the ZLIB module. It adds missing names like zlib1 of the official zlib binary package. It allows to specify a ZLIB_ROOT_PATH too.

http://git.cryptomilk.org/projects/cmake-tools.git/tree/modules/zlib/FindZLIB.cmake [^]

I can send git patches if you're interested.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch 0002-Modules-Added-an-improved-version-of-the-ZLIB-module.patch (7,442) 2011-01-16 06:32
https://public.kitware.com/Bug/file/3628/0002-Modules-Added-an-improved-version-of-the-ZLIB-module.patch
Issue History
Date ModifiedUsernameFieldChange
2011-01-16 06:03Andreas Schneider.New Issue
2011-01-16 06:32Andreas Schneider.File Added: 0002-Modules-Added-an-improved-version-of-the-ZLIB-module.patch
2011-01-17 11:12Brad KingAssigned To => Kovarththanan Rajaratnam
2011-01-17 11:12Brad KingStatusnew => assigned
2011-01-17 11:14Brad KingNote Added: 0024757
2011-01-17 16:34Brad KingNote Added: 0024825
2011-02-10 12:34Andreas Schneider.Note Added: 0025375
2011-02-10 13:04Brad KingNote Added: 0025379
2011-02-10 13:39Andreas Schneider.Note Added: 0025380
2011-02-10 13:48Brad KingNote Added: 0025382
2011-02-10 13:52Andreas Schneider.Note Added: 0025383
2011-08-20 06:46Andreas Schneider.Note Added: 0027253
2011-08-20 06:47Andreas Schneider.Statusassigned => resolved
2011-08-20 06:47Andreas Schneider.Fixed in Version => CMake 2.8.6
2011-08-20 06:47Andreas Schneider.Resolutionopen => fixed
2011-09-12 17:20David ColeTarget Version => CMake 2.8.6
2012-02-06 06:07David ColeNote Added: 0028507
2012-02-06 06:07David ColeStatusresolved => closed

Notes
(0024757)
Brad King   
2011-01-17 11:14   
Assigned to Kovarththanan Rajaratnam, the current maintainer of the FindZLIB module:

  http://www.cmake.org/Wiki/index.php?title=CMake:Module_Maintainers&oldid=35938 [^]
(0024825)
Brad King   
2011-01-17 16:34   
The patch 0002-Modules-Added-an-improved-version-of-the-ZLIB-module.patch combines changes like upper->lower case conversion with real modifications. Can you please split this into a patch series that first performs the case conversion, then any refactoring needed, then adds the features? That will be much easier to review.
(0025375)
Andreas Schneider.   
2011-02-10 12:34   
I can do that but this means that I have to write 3 patches of nearly the same size.

It is more or less a complete rewrite of the Module.
(0025379)
Brad King   
2011-02-10 13:04   
0011706:0025375: Okay, we'll just review the new whole module. Thanks.

Are you interested in becoming the maintainer as described in 0011706:0024757?
(0025380)
Andreas Schneider.   
2011-02-10 13:39   
I think you already gave me commit access.

I've just updated all modules to reflect the latest changes in CMake. I've based them on the next branch and put them on my wip repo.

http://git.cryptomilk.org/users/asn/cmake.git/log/ [^]

Just want to be sure that I'm doing it correctly.
(0025382)
Brad King   
2011-02-10 13:48   
Please base work on 'master'. Otherwise we can't merge it independently of the other work in 'next'.
(0025383)
Andreas Schneider.   
2011-02-10 13:52   
Done.

http://git.cryptomilk.org/users/asn/cmake.git/log/ [^]

I'm a little bit confused of next and master and where I should push changes then :)

I'm in #cmake at freenode as gladiac by the way ;)
(0027253)
Andreas Schneider.   
2011-08-20 06:46   
Pushed to staging server.
(0028507)
David Cole   
2012-02-06 06:07   
Closing resolved issues that have not been updated in more than 4 months.