View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0011706 | CMake | (No Category) | public | 2011-01-16 06:03 | 2012-02-06 06:07 | ||||
Reporter | Andreas Schneider. | ||||||||
Assigned To | Kovarththanan Rajaratnam | ||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | CMake 2.8.6 | Fixed in Version | CMake 2.8.6 | ||||||
Summary | 0011706: Improved version of FindZLIB | ||||||||
Description | This is an improved version of the ZLIB module. It adds missing names like zlib1 of the official zlib binary package. It allows to specify a ZLIB_ROOT_PATH too. http://git.cryptomilk.org/projects/cmake-tools.git/tree/modules/zlib/FindZLIB.cmake [^] I can send git patches if you're interested. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | 0002-Modules-Added-an-improved-version-of-the-ZLIB-module.patch [^] (7,442 bytes) 2011-01-16 06:32 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0024757) Brad King (manager) 2011-01-17 11:14 |
Assigned to Kovarththanan Rajaratnam, the current maintainer of the FindZLIB module: http://www.cmake.org/Wiki/index.php?title=CMake:Module_Maintainers&oldid=35938 [^] |
(0024825) Brad King (manager) 2011-01-17 16:34 |
The patch 0002-Modules-Added-an-improved-version-of-the-ZLIB-module.patch combines changes like upper->lower case conversion with real modifications. Can you please split this into a patch series that first performs the case conversion, then any refactoring needed, then adds the features? That will be much easier to review. |
(0025375) Andreas Schneider. (developer) 2011-02-10 12:34 |
I can do that but this means that I have to write 3 patches of nearly the same size. It is more or less a complete rewrite of the Module. |
(0025379) Brad King (manager) 2011-02-10 13:04 |
0011706:0025375: Okay, we'll just review the new whole module. Thanks. Are you interested in becoming the maintainer as described in 0011706:0024757? |
(0025380) Andreas Schneider. (developer) 2011-02-10 13:39 |
I think you already gave me commit access. I've just updated all modules to reflect the latest changes in CMake. I've based them on the next branch and put them on my wip repo. http://git.cryptomilk.org/users/asn/cmake.git/log/ [^] Just want to be sure that I'm doing it correctly. |
(0025382) Brad King (manager) 2011-02-10 13:48 |
Please base work on 'master'. Otherwise we can't merge it independently of the other work in 'next'. |
(0025383) Andreas Schneider. (developer) 2011-02-10 13:52 |
Done. http://git.cryptomilk.org/users/asn/cmake.git/log/ [^] I'm a little bit confused of next and master and where I should push changes then :) I'm in #cmake at freenode as gladiac by the way ;) |
(0027253) Andreas Schneider. (developer) 2011-08-20 06:46 |
Pushed to staging server. |
(0028507) David Cole (manager) 2012-02-06 06:07 |
Closing resolved issues that have not been updated in more than 4 months. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2011-01-16 06:03 | Andreas Schneider. | New Issue | |
2011-01-16 06:32 | Andreas Schneider. | File Added: 0002-Modules-Added-an-improved-version-of-the-ZLIB-module.patch | |
2011-01-17 11:12 | Brad King | Assigned To | => Kovarththanan Rajaratnam |
2011-01-17 11:12 | Brad King | Status | new => assigned |
2011-01-17 11:14 | Brad King | Note Added: 0024757 | |
2011-01-17 16:34 | Brad King | Note Added: 0024825 | |
2011-02-10 12:34 | Andreas Schneider. | Note Added: 0025375 | |
2011-02-10 13:04 | Brad King | Note Added: 0025379 | |
2011-02-10 13:39 | Andreas Schneider. | Note Added: 0025380 | |
2011-02-10 13:48 | Brad King | Note Added: 0025382 | |
2011-02-10 13:52 | Andreas Schneider. | Note Added: 0025383 | |
2011-08-20 06:46 | Andreas Schneider. | Note Added: 0027253 | |
2011-08-20 06:47 | Andreas Schneider. | Status | assigned => resolved |
2011-08-20 06:47 | Andreas Schneider. | Fixed in Version | => CMake 2.8.6 |
2011-08-20 06:47 | Andreas Schneider. | Resolution | open => fixed |
2011-09-12 17:20 | David Cole | Target Version | => CMake 2.8.6 |
2012-02-06 06:07 | David Cole | Note Added: 0028507 | |
2012-02-06 06:07 | David Cole | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |