[Insight-developers] [PATCH] for ITK 3.20 branch for invalid use of ints with std::complex

Matt McCormick matt.mccormick at kitware.com
Fri May 4 18:52:51 EDT 2012


Thanks, Sean.

The patch has been merged into the release-3.20 branch along with
another patch of yours I found on github:

http://itk.org/gitweb?p=ITK.git;a=commit;h=a12687704a10fe7a7c5057278ba5caa956d608ce
http://itk.org/gitweb?p=ITK.git;a=commit;h=4c2bfb739d2ec073e1f1477e576d656195edbb11

Thanks,
Matt

On Wed, May 2, 2012 at 2:52 PM, Sean McBride <sean at rogue-research.com> wrote:
> Hi all,
>
> Attached is a small patch removing undefined behaviour in 3.20.
>
> History: I tried to build my own app against libc++ <http://libcxx.llvm.org/> and it failed against one of ITK 3.20's public headers.  Apparently it's undefined behaviour to template std::complex with integer types:
> <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2012-March/020398.html>
>
> This code seems to already be gone in ITK 4.
>
> PS: I'll be changing my ITK dashboards to use libc++... when I have some time...
>
> Thanks,
>
> --
> ____________________________________________________________
> Sean McBride, B. Eng                 sean at rogue-research.com
> Rogue Research                        www.rogue-research.com
> Mac Software Developer              Montréal, Québec, Canada
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>


More information about the Insight-developers mailing list