[Insight-developers] NumericTraits for RGBPixel

[Gaëtan Lehmann]

Hi,

I'm fixing the bug uncovered by Julien Michel in  
ConnectedComponentImageFilter with RGB images as input, and want to  
add a test for it.
However, I can't succeed to build the modified test because  
itk::NumericTraits< RGBPixelType< unsigned char > >::max() is not  
defined.
Is it done on purpose?

Also, some functions defined in those numeric traits look suspicious  
to me, like

   typedef _TYPENAME_ NumericTraits<T>::RealType        
ElementRealType; \
   typedef RGBPixel<ElementRealType>         RealType; \
   static const RealType max( const Self & a ) \
     {  \
       RealType b(a.Size());  \
       b.Fill( NumericTraits< T >::max() ); \
       return b; \
     } \

Why should max( const Self & a ) return a RealType? Why b inside the  
function is filled with the size of a (which is always 3), and then  
filled with zeros?
For the scalar types, that function simply return the value of max().

Regards,

Gaëtan


-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr  http://www.mandriva.org
http://www.itk.org  http://www.clavier-dvorak.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: Ceci est une signature ?lectronique PGP
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090114/e801fec8/attachment.pgp>