[Insight-developers] GlobalReleaseDataFlag and ReleaseData testing : SunCC build fixed

[Bradley Lowekamp]

>
>
> It is unclear why the CC compiler suddenly cares about it.
>
>

No one ever used it before!?!  Please grep for ReleaseData in the  
Examples and Test directories. This feature is nearly not tested!

I just added it in this test:
http://www.itk.org/cgi-bin/viewcvs.cgi/Testing/Code/BasicFilters/itkReleaseDataFilterTest.cxx?root=Insight&sortby=date&view=markup


Brad

>    Luis
>
>
>
> ---------------------
> Bill Lorensen wrote:
>> Brad,
>>
>> The Sun compiler is having trouble with your change:
>>
>> http://www.cdash.org/CDash/viewBuildError.php?buildid=275733
>>
>> Bill
>>
>> On Thu, Feb 19, 2009 at 12:47 PM, Luis Ibanez <luis.ibanez at kitware.com 
>> > wrote:
>>
>>> Hi Brad,
>>>
>>> Good idea to check against VTK.
>>>
>>> My vote would be to run an Experimental build with the change,
>>> and if it gets out green, just commit the change.
>>>
>>> Looking at the code, it doesn't seems that the change should
>>> have any implications, ... but we have said the same many
>>> time before  :-)
>>>
>>>
>>> Thanks
>>>
>>>
>>>  Luis
>>>
>>>
>>> ----------------------------
>>> Bradley Lowekamp wrote:
>>>
>>>> I checked VTK as I think DataObject came from there. These  
>>>> methods are
>>>> also non static there too.
>>>>
>>>>
>>>> On Feb 19, 2009, at 10:26 AM, Luis Ibanez wrote:
>>>>
>>>>
>>>>> Hi Brad,
>>>>>
>>>>> Thanks for pointing this out.
>>>>>
>>>>> I agree with you in that the methods:
>>>>>
>>>>>
>>>>> void itk::DataObject::GlobalReleaseDataFlagOn()
>>>>> void itk::DataObject::GlobalReleaseDataFlagOff()
>>>>>
>>>>>
>>>>> should be static.
>>>>>
>>>>> The only thing they are doing, is calling
>>>>> another static method.
>>>>>
>>>>>
>>>>>  Luis
>>>>>
>>>>>
>>>>> ---------------------
>>>>> Bradley Lowekamp wrote:
>>>>>
>>>>>
>>>>>> Hello,
>>>>>
>>>>>> I am working on this bug:
>>>>>
>>>>>> http://www.itk.org/Bug/view.php?id=8490
>>>>>
>>>>>> I wanted to verify my assertion, that this same bug would be  
>>>>>> problematic
>>>>>
>>>>>> for the ReleaseData flag. So I searched to see what testing we  
>>>>>> do of
>>>>>> that:
>>>>>
>>>>>> victoria:Insight/Testing blowek1$ grep -R ReleaseData *
>>>>>
>>>>>> Code/BasicFilters/itkThresholdImageFilterTest.cxx:
>>>>>
>>>>>> random->ReleaseDataFlagOn();
>>>>>
>>>>>> Thats not much testing of this option! So I am writing a test  
>>>>>> to do a
>>>>>
>>>>>> little more testing of it. I notice that in in itkDataObject we  
>>>>>> have the
>>>>>
>>>>>> following:
>>>>>
>>>>>> static void SetGlobalReleaseDataFlag(const bool val);
>>>>>
>>>>>> static bool GetGlobalReleaseDataFlag();
>>>>>
>>>>>> void GlobalReleaseDataFlagOn()
>>>>>
>>>>>> {this->SetGlobalReleaseDataFlag(true);}
>>>>>
>>>>>> void GlobalReleaseDataFlagOff()
>>>>>
>>>>>> {this->SetGlobalReleaseDataFlag(false);}
>>>>>
>>>>>> I can't think of any reason why the On/Off methods are not  
>>>>>> static. It
>>>>>
>>>>>> appears to be there since day one. Any objections to changing  
>>>>>> them to
>>>>>
>>>>>> static?
>>>>>
>>>>>> Brad
>>>>>

========================================================
Bradley Lowekamp
Lockheed Martin Contractor for
Office of High Performance Computing and Communications
National Library of Medicine
blowekamp at mail.nih.gov


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090220/6f5557ce/attachment.htm>