[Insight-developers] Nonportable Code

Fri Aug 14 13:21:11 EDT 2009

Le 14 août 09 à 19:15, Bill Lorensen a écrit :

> We need itkIntTypes.h because we have released it. If possible, it
> should be repaired.

Sure - I wasn't thinking to break backward compatibility. The question  
was more related to vxl code: is it broken somehow, so we have to have  
this file to make our own fixes?

>
> Gaëtan, we can't afford to have so many compiles breaking this close
> to a release.
>
> I am concerned about making such fundamental changes so close to the
> release. These should be made during the early part of the release
> cycle.

I thought it would be a simple fix, but I was wrong. We can revert the  
changes if you prefer.

Gaëtan

>
> Bill
>
> 2009/8/14 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>>
>> Le 14 août 09 à 17:25, Bradley Lowekamp a écrit :
>>
>>> Hello,
>>>
>>> Because one option is never enough.
>>> There is also itkIntType.h which defines
>>>
>>> ITK_INT64
>>>
>>> But there are other types defined there that appear wrong (maybe?  
>>> most
>>> likely?), so I am not sure how much this file is worth!
>>
>> I've used that option, but I'm quite sure the types defined there  
>> are wrong.
>> For example,
>>
>>  #ifdef _WIN32
>>    typedef long      ITK_INT64;
>>  #endif
>>
>> and
>>
>>  #ifdef _WIN32
>>    typedef unsigned long ITK_UINT64;
>>  #endif
>>
>> don't like right to me.
>>
>>  http://msdn.microsoft.com/en-us/library/s3f49ktz.aspx
>>
>>
>> Tom's way - vxl_int_64 - seems to be a better option.
>>
>> Should we fix the content of itkIntType.h by using vxl_int_64 types?
>> And do we even need itkIntType.h?
>>
>> Gaëtan
>>
>>
>>
>>>
>>> Brad
>>>
>>>
>>> On Aug 14, 2009, at 11:05 AM, Tom Vercauteren wrote:
>>>
>>>> Hey Gaëtan,
>>>>
>>>> I am not sure if it's really portable since I have only tried it  
>>>> on a
>>>> single computer, but there is already an attempt in vxl to define a
>>>> portable 64 bit integer:
>>>>
>>>>  vxl_int_64
>>>>
>>>> It might be worth giving it a try.
>>>>
>>>> Tom
>>>>
>>>> 2009/8/14 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>>>>>
>>>>> Le 14 août 09 à 16:18, Bill Lorensen a écrit :
>>>>>
>>>>>> Gaëtan,
>>>>>>
>>>>>> Before you get too far along with your changes, please note  
>>>>>> that they
>>>>>> are nor portable.
>>>>>>
>>>>>> http://www.cdash.org/CDash/viewBuildError.php?buildid=402018
>>>>>> http://www.cdash.org/CDash/viewBuildError.php?buildid=402019
>>>>>
>>>>>
>>>>> Things can't be simple with so much compilers :-)
>>>>> I guess I should rather use the type __int64 or int64_t already  
>>>>> used
>>>>> elsewhere.
>>>>>
>>>>> Regards,
>>>>>
>>>>> Gaëtan
>>>>>
>>>>> --
>>>>> Gaëtan Lehmann
>>>>> Biologie du Développement et de la Reproduction
>>>>> INRA de Jouy-en-Josas (France)
>>>>> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
>>>>> http://voxel.jouy.inra.fr  http://www.itk.org
>>>>> http://www.mandriva.org  http://www.bepo.fr
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Powered by www.kitware.com
>>>>>
>>>>> Visit other Kitware open-source projects at
>>>>> http://www.kitware.com/opensource/opensource.html
>>>>>
>>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>>
>>>>> Follow this link to subscribe/unsubscribe:
>>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>>>
>>>>>
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>
>>> ========================================================
>>> Bradley Lowekamp
>>> Lockheed Martin Contractor for
>>> Office of High Performance Computing and Communications
>>> National Library of Medicine
>>> blowekamp at mail.nih.gov
>>>
>>>
>>
>> --
>> Gaëtan Lehmann
>> Biologie du Développement et de la Reproduction
>> INRA de Jouy-en-Josas (France)
>> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
>> http://voxel.jouy.inra.fr  http://www.itk.org
>> http://www.mandriva.org  http://www.bepo.fr
>>
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>

-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr  http://www.itk.org
http://www.mandriva.org  http://www.bepo.fr

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 203 bytes
Desc: Ceci est une signature ?lectronique PGP
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090814/edc14863/attachment.pgp>