[Ctk-developers] Crash in ~OFCondition()

[Jean-Christophe Fillion-Robin]

Hi Marco,

I don't remember any particular issue with building DCMTK as shared
library. That said, we should make sure it compiles as expected on windows
and also work as expected when installed / packaged.

The motivation with having such external dependencies build statically
makes the install of CTK tree easier. Indeed, doing something like [1] is
enough to install all runtime libraries provided directly by CTK.

We could also think about a better way to specify which component
associated with external project should be installed when installing CTK.
Currently we a using something like [2] to install the DCMTK application.

Building statically also prevents possible issues when using DCMTK apps
directly from the command line. There is no need for a launcher or no need
to enforce that the DCMTK shared libraries are in a specific location.

Thanks
Jc

[1]
https://github.com/Slicer/Slicer/blob/master/CMake/SlicerBlockInstallCMakeProjects.cmake#L47
[2]
https://github.com/Slicer/Slicer/blob/master/CMake/SlicerBlockInstallDCMTKApps.cmake
On Wed, Feb 15, 2012 at 11:04 AM, Marco Nolden
<m.nolden at dkfz-heidelberg.de>wrote:

> Hi Jörg,
>
> thanks. I just changed the DCMTK build type to SHARED inside of CTK and it
> worked as well (plain 3.6 release). Unfortunately I can't remember why we
> switched to static. For windows? jc?
>
> Since updating everything to some intermediate version of DCMTK has a lot
> of implications for us we would prefer to use this solution if possible.
> Let's wait if anyone can remember why a shared DCMTK was a bad idea ...
>
> Best,
> Marco
>
>
> On 02/15/2012 04:18 PM, OFFIS DICOM Team wrote:
>
>> Hi Marco,
>>
>>
>>  I'm also affected by the problem now on Fedora 16. Is there any
>>> workaround? I can't start our application at all.
>>>
>>
>> good question. We've just committed a major rewrite of the OFCondition
>> class
>> that should solve this (and all related) issues:
>>
>>
>> http://git.dcmtk.org/web?p=**dcmtk.git;a=commit;h=**
>> 19ec80fae2dda21af1d3c3eb9be279**a64c70e21e<http://git.dcmtk.org/web?p=dcmtk.git;a=commit;h=19ec80fae2dda21af1d3c3eb9be279a64c70e21e>
>>
>> Unfortunately, I could not test yet whether it really works with Julien's
>> test program. This is something I have to do this evening with my private
>> notebook (Ubuntu 11.10), a system on which I could reproduce the crash
>> with
>> the old implementation.
>>
>> Regards,
>> Jörg Riesmeier
>>
>
>
> --
> ------------------------------**------------------------------**----------
> Dipl.-Inform. Med. Marco Nolden
> Deutsches Krebsforschungszentrum       (German Cancer Research Center)
> Div. Medical & Biological Informatics          Tel: (+49) 6221-42 2325
> Im Neuenheimer Feld 280                        Fax: (+49) 6221-42 2345
> D-69120 Heidelberg                             eMail: M.Nolden at dkfz.de
> ______________________________**_________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-**bin/mailman/listinfo/ctk-**developers<http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers>
>



-- 
+1 919 869 8849
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20120215/0e4566d9/attachment.html>