[CMake] cmLocalGenerator::GenerateInstallRules() needlessly slow?/missing optimization?

[Andreas Mohr]

On Tue, Sep 13, 2011 at 03:33:01PM +0200, Alexander Neundorf wrote:
> On Wednesday, September 07, 2011 11:12:55 AM Andreas Mohr wrote:
> > Depending on actual implementation of CMake (whether it has some caching
> > logic or not), this might be woefully inefficient,
> > causing a possibly _filesystem-bound_ file append for each line.
> 
> Without checking, AFAIK it hasn't.
> But, I never had the impression that this part of "make install" would be 
> slow, so I'm not sure it is worth it.

Yeah, I'm afraid it's not a hotpath, thus it's not necessarily worth
optimizing.

> Did you notice slow install behaviour ?

No, it simply occurred to me that this construct might be a lot more
inefficient than storing content of a helper array...
One would probably have to analyse an strace trace (or some such)
of a full install to be able to pinpoint specifics.

Andreas Mohr