[CMake] cmLocalGenerator::GenerateInstallRules() needlessly slow?/missing optimization?

Alexander Neundorf a.neundorf-work at gmx.net
Tue Sep 13 09:33:01 EDT 2011


On Wednesday, September 07, 2011 11:12:55 AM Andreas Mohr wrote:
> Hi,
> 
> just saw that the main cmake_install.cmake contains (at the end):
> 
> FILE(WRITE
> "[${CMAKE_BINARY_DIR}]/${CMAKE_INSTALL_MANIFEST}"
> "")
> FOREACH(file ${CMAKE_INSTALL_MANIFEST_FILES})
>   FILE(APPEND
> "[${CMAKE_BINARY_DIR}]/${CMAKE_INSTALL_MANIFEST}"
> "${file}\n")
> ENDFOREACH(file)
> 
> as generated by CMake git
> Source/cmLocalGenerator.cxx/cmLocalGenerator::GenerateInstallRules()
> 
> Depending on actual implementation of CMake (whether it has some caching
> logic or not), this might be woefully inefficient,
> causing a possibly _filesystem-bound_ file append for each line.

Without checking, AFAIK it hasn't.
But, I never had the impression that this part of "make install" would be 
slow, so I'm not sure it is worth it.
Did you notice slow install behaviour ?

Alex


More information about the CMake mailing list