[CMake] CTest: use 'make -k' instead of 'make -i'

[Michael Wild]

On 25. Oct, 2010, at 16:45 , Marcel Loose wrote:

> Hi all,
> 
> I noticed that 'ctest -DExperimentalBuild' returns with an exit status
> 0, even if compiler errors occur. I think that is caused by the fact
> that 'make -i' is used. The "-i|--ignore-errors" option causes make to
> always exit with status 0. 
> 
> Wouldn't it make more sense to use 'make -k' instead? 
> The "-k|--keep-going" option tries to build as much as possible, but
> won't try to build targets that depend on sources that failed to
> compile. Furthermore, and more importantly, 'make -k' will return with
> an exit status unequal to 0, if compiler errors occurred. 
> 
> Best regards,
> Marcel Loose.

Some weeks ago I also wanted to propose this, but then realized one important drawback of -k: Say, you have target B depending on A. If A fails, nothing from B will be compiled, thus hiding programming errors that will only show up once A is fixed. What needs to be fixed is the error parser in CTest.

Michael

--
There is always a well-known solution to every human problem -- neat, plausible, and wrong.
H. L. Mencken

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
URL: <http://www.cmake.org/pipermail/cmake/attachments/20101025/c8d0dc90/attachment.pgp>