[CMake] Patches with "your name" all over them?
Andreas Pakulat
apaku at gmx.de
Mon Mar 23 03:36:37 EDT 2009
On 22.03.09 16:15:22, Bob Tanner wrote:
> I'm attempting to get cmake build system into "upstream" which currently
> uses the autotools.
>
> The upstream developers do not like "my name" all over the patch.
>
> Looking into cmake files, I do see my name all over :-)
Seems like you did an in-source build. CMake suggests to use out-of-source
builds at all times so your source directory stays clean.
> Am
>
> I adding the wrong files to upstream?
Yes, the ones you mentioned are files generated by cmake when you run
cmake.
> Are the things "#" (hashed) just comments and I can remove them from the file?
Don't add the files at all.
> Any documentation on what files (minimaly) need to be added to revision
> control so projects can build?
The ones you've written yourself :) In general cmake only needs the
CMakeLists.txt files and any other files you've written specifically for
building the project (like .cmake find-modules or .cmake template files
used with configure_file). Anything else is generated by cmake when you ran
it in the source tree.
Andreas
--
Domestic happiness and faithful friends.
More information about the CMake
mailing list