[cmake-developers] [PATCH] FindBoost: Add imported targets

Brad King brad.king at kitware.com
Mon Nov 30 11:33:20 EST 2015


On 11/30/2015 11:26 AM, rleigh at codelibre.net wrote:
> I have improved the parsing speed somewhat and added some progress
> diagnostics to inform the user what's happening to compensate for the time
> it takes to process the dependencies.  It's still slower than I'd ideally
> like, but it's a bit better.  If there's any way to make it even faster
> I'd be interested.  I think what's there is technically correct though.

I'm sorry I didn't have a chance to look at this sooner.

Parsing dependencies out of the header files is far too heavy-weight
for a find module.  We should memorize the known dependencies as
is done for other find modules that provide imported targets.  If
that is not tractable then the FindBoost module is the wrong place
to solve this problem.

FWIW, I think effort would be better spent working with Boost
folks to get cmake package files provided.  They don't have to
build with CMake to do this.  Qt5 for example builds without
CMake but still provides CMake package files.

-Brad



More information about the cmake-developers mailing list