[cmake-developers] [PATCH] FindBoost: Add imported targets

[rleigh at codelibre.net]

> On 18/11/2015 11:27, rleigh at codelibre.net wrote:
>>> On 11/16/2015 09:26 AM, Florent Castelli wrote:
>>>> But one there’s one thing that comes to mind. Some compiled
>>>> libraries
>>>> have dependencies on other compiled libraries.
>>>> Don’t you think it would make sense to teach FindBoost about those
>>>> so we link everything properly?
>>>>
>>>> And also maybe add the native dependencies for some modules that
>>>> have one like maybe pthread or openssl.
>>>> Though, this might be hard to get right in a cross platform way.
>>>
>>> Please look at adding these.  The imported targets should come
>>> with all usage requirements as if they were provided by upstream
>>> Boost.  It may be tricky to get right on all platforms but if we
>>> do not do it then application code will have to do it instead.
>>
>> I have made a first attempt at this.  I suspect it will need some
>> refinement, but hopefully useful as a starting point.  Please see the
>> attached patch.  I'd certainly be very appreciative of any comments.
>
> [...]
>
> Did anyone have a chance to look at this yet?  I'd very much like to get
> this to a state where it can be included.  The performance is something
> I'd like to improve, and I hope someone might have a suggestion for
> speeding up the parsing overhead.

I have improved the parsing speed somewhat and added some progress
diagnostics to inform the user what's happening to compensate for the time
it takes to process the dependencies.  It's still slower than I'd ideally
like, but it's a bit better.  If there's any way to make it even faster
I'd be interested.  I think what's there is technically correct though.


Regards,
Roger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-FindBoost-Add-imported-targets.patch
Type: text/x-diff
Size: 16327 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20151130/55e8d7db/attachment.patch>