[cmake-developers] remove obsolete link directories from SunOS.cmake

[A Chin]

Thanks, Brad.

Update to my previous email--I forgot that we have switched to building
cmake 3.3.2 with
gcc 4.8.2 now, not Studio.

Here's what I see, on x86,
CMakeCCompiler.cmake:
set(CMAKE_C_IMPLICIT_LINK_DIRECTORIES
"/lib/amd64;/usr/lib/amd64;/usr/gcc/4.8/lib/gcc/i386-pc-solaris2.12/4.8.2/amd64;/usr/gcc/4.8/lib/amd64;/usr/gcc/4.8/lib/gcc/i386-pc-solaris2.12/4.8.2;/usr/gcc/4.8/lib")

CMakeCXXCompiler.cmake:
set(CMAKE_CXX_IMPLICIT_LINK_DIRECTORIES
"/lib/amd64;/usr/lib/amd64;/usr/gcc/4.8/lib/gcc/i386-pc-solaris2.12/4.8.2/amd64;/usr/gcc/4.8/lib/amd64;/usr/gcc/4.8/lib/gcc/i386-pc-solaris2.12/4.8.2;/usr/gcc/4.8/lib")

and on sparc,
CMakeCCompiler.cmake:
set(CMAKE_C_IMPLICIT_LINK_DIRECTORIES
"/lib/sparcv9;/usr/lib/sparcv9;/usr/gcc/4.8/lib/gcc/sparc-sun-solaris2.12/4.8.2/sparcv9;/usr/gcc/4.8/lib/sparcv9;/usr/gcc/4.8/lib/gcc/sparc-sun-solaris2.12/4.8.2;/usr/ccs/lib;/usr/gcc/4.8/lib")

CMakeCXXCompiler.cmake:
set(CMAKE_CXX_IMPLICIT_LINK_DIRECTORIES
"/lib/sparcv9;/usr/lib/sparcv9;/usr/gcc/4.8/lib/gcc/sparc-sun-solaris2.12/4.8.2/sparcv9;/usr/gcc/4.8/lib/sparcv9;/usr/gcc/4.8/lib/gcc/sparc-sun-solaris2.12/4.8.2;/usr/ccs/lib;/usr/gcc/4.8/lib")

Thanks,
April



On Mon, Nov 16, 2015 at 7:42 AM, Brad King <brad.king at kitware.com> wrote:

> On 11/13/2015 05:40 PM, A Chin wrote:
> > I tested using Solaris Studio 12.4 on our latest Solaris development
> release,
> > post Solaris 11 Update 3.
> [snip]
> On 11/13/2015 03:05 PM, C Bergström wrote:
> > At a glance - I'd 1/2 agree with you on what SS will do.
> > /opt/SUNWspro/lib /opt/SUNWspro/prod/lib - These or corresponding dir/
> > should be added automatically
> >
> > /usr/ccs/lib - I don't know if this will be added by default. crle
> > isn't showing it on a default system. I didn't check the SS link line.
>
> Please check CMakeFiles/*/CMake{C,CXX}Compiler.cmake to see what
> CMAKE_<LANG>_IMPLICIT_LINK_DIRECTORIES are detected.  The detection
> logic that populates these works from the actual toolchain and
> supersedes the need for CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES
> to be hard-coded with such entries.
>
> If the detection logic is working well then there is no need to keep
> the hard-coded setting even if the values were still needed on older
> systems.  I've applied the change accordingly:
>
>  SunOS: Remove obsolete Studio compiler library directories
>  https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6772913f
>
> Thanks,
> -Brad
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20151116/289e2dae/attachment.html>