[cmake-developers] patch to fix installed size for cpack PackageMaker generator
Calin Cascaval
cascaval at acm.org
Fri Dec 26 12:55:15 EST 2014
Brad, Sean,
The patch is attached. I tested it with a few settings (10.4, 10.5, and 10.10) on a 10.9.5 system. Unfortunately I don’t have a 10.10 machine, however, the package built with a 10.10 option looks good.
--
Thanks, Calin
On Dec 22, 2014, at 7:57, Brad King <brad.king at kitware.com> wrote:
> On 12/22/2014 10:52 AM, Sean McBride wrote:
>> I had started a patch but haven't had time to test it. Perhaps
>> you could continue from where I left off, see attached.
>
> Thanks, Sean. Calin, the patch currently hard-codes encoding of
> the major and minor versions into an integer:
>
> this->PackageCompatibilityVersion = ((10 << 16) | 4);
>
> I think the encoding is a good approach, but please factor it out
> into a helper macro (local to the .cxx file) so the encoding logic
> does not have to be repeated.
>
> Thanks,
> -Brad
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141226/d50f75f9/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-PackageMaker-fixes-version-format.patch
Type: application/octet-stream
Size: 4790 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141226/d50f75f9/attachment-0001.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141226/d50f75f9/attachment-0003.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4130 bytes
Desc: not available
URL: <http://public.kitware.com/pipermail/cmake-developers/attachments/20141226/d50f75f9/attachment-0001.bin>
More information about the cmake-developers
mailing list