| View Issue Details [ Jump to Notes ] | [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0009496 | CMake | Modules | public | 2009-09-05 04:54 | 2010-05-09 05:09 |
|
| Reporter | Mauro Toffanin | |
| Assigned To | Alex Neundorf | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | x86 | OS | Gentoo | OS Version | 2008.0 |
| Product Version | CMake-2-6 | |
| Target Version | | Fixed in Version | | |
|
| Summary | 0009496: FindOpenAL.cmake: Enhancements for missing QUIET/REQUIRED and MARK_AS_ADVANCED |
| Description | I have added QUIET/REQUIRED arguments using FIND_PACKAGE_HANDLE_STANDARD_ARGS module and added also MARK_AS_ADVANCED options to let end users overwrite variables: OPENAL_LIBRARY OPENAL_INCLUDE_DIR.
Hope to be useful.
Mauro Toffanin |
| Tags | No tags attached. |
|
| Attached Files |  FindOpenAL.cmake.patch [^] (589 bytes) 2009-09-05 04:54 [Show Content] [Hide Content]--- Modules/FindOpenAL.cmake 2009-09-05 10:32:49.193989587 +0200
+++ Modules/FindOpenAL.cmake 2009-09-05 10:35:04.649987871 +0200
@@ -82,8 +82,9 @@
)
-SET(OPENAL_FOUND "NO")
-IF(OPENAL_LIBRARY AND OPENAL_INCLUDE_DIR)
- SET(OPENAL_FOUND "YES")
-ENDIF(OPENAL_LIBRARY AND OPENAL_INCLUDE_DIR)
+# handle the QUIETLY and REQUIRED arguments and set OPENAL_FOUND to TRUE if
+# all listed variables are TRUE
+INCLUDE(FindPackageHandleStandardArgs)
+FIND_PACKAGE_HANDLE_STANDARD_ARGS(OpenAL DEFAULT_MSG OPENAL_LIBRARY OPENAL_INCLUDE_DIR)
+MARK_AS_ADVANCED(OPENAL_LIBRARY OPENAL_INCLUDE_DIR)
|
|