View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0009431ITKpublic2009-08-17 06:562010-10-21 12:31
ReporterCharl Botha 
Assigned ToBradley Lowekamp 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0009431: CannyEdgeDetectionImageFilter gives different output for same parameters and input after repeated runs
DescriptionIn short, the canny filter's behaviour changes depending on whether it has been freshly instantiated or whether it has been used with a different parameter setting before. Setting the threshold back to a previous value after having executed the filter with different values will yield incorrect results.

Running the attached Python script on Insight/Testing/Data/Input/cthead1.png yields 4 images on disc, of which canny_t0.png and canny_t0_after.png should be identical, as they are using the same thresholds, and otherwise identical parameters. However, they are wildly different, see the attached images.
TagsNo tags attached.
Resolution Date
Sprint
Sprint Status
Attached Files? file icon CannyEdgeDetectionImageFilter_repeat_bug.py [^] (1,102 bytes) 2009-08-17 06:56
png file icon canny_t0.png [^] (10,986 bytes) 2009-08-17 06:57


png file icon canny_t0_after.png [^] (15,670 bytes) 2009-08-17 06:57

 Relationships

  Notes
(0017143)
Bradley Lowekamp (developer)
2009-08-17 07:57

 I have a patch for this bug, but it is a VTK category so I can't assign it to myself.
(0017144)
Charl Botha (reporter)
2009-08-17 08:05

 Argh, my default category is VTK and I didn't see that when I submitted this bug. Is there someone that can fix it? I'm not able to change it AFAICS.

Great that you have a fix for this!!
(0017145)
Bradley Lowekamp (developer)
2009-08-17 08:20
edited on: 2009-08-17 08:20

 submitted patch:

http://public.kitware.com/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkCannyEdgeDetectionImageFilter.txx?revision=1.56&root=Insight&view=markup [^]
(0017148)
Bradley Lowekamp (developer)
2009-08-17 10:05

 added test:

http://public.kitware.com/cgi-bin/viewcvs.cgi/Testing/Code/BasicFilters/CMakeLists.txt.diff?cvsroot=Insight&r1=1.392&r2=1.393 [^]
http://public.kitware.com/cgi-bin/viewcvs.cgi/Testing/Code/BasicFilters/itkBasicFiltersTests.cxx.diff?cvsroot=Insight&r1=1.123&r2=1.124 [^]
http://public.kitware.com/cgi-bin/viewcvs.cgi/Testing/Code/BasicFilters/itkCannyEdgeDetectionImageFilterTest2.cxx?cvsroot=Insight&rev=1.1&view=markup [^]
(0017156)
Bradley Lowekamp (developer)
2009-08-18 14:41

 the submitted patch passed on all nightly builds

 Issue History
Date Modified Username Field Change
2009-08-17 06:56 Charl Botha New Issue
2009-08-17 06:56 Charl Botha File Added: CannyEdgeDetectionImageFilter_repeat_bug.py
2009-08-17 06:57 Charl Botha File Added: canny_t0.png
2009-08-17 06:57 Charl Botha File Added: canny_t0_after.png
2009-08-17 07:57 Bradley Lowekamp Note Added: 0017143
2009-08-17 08:05 Charl Botha Note Added: 0017144
2009-08-17 08:20 Bradley Lowekamp Note Added: 0017145
2009-08-17 08:20 Bradley Lowekamp Note Edited: 0017145
2009-08-17 10:05 Bradley Lowekamp Note Added: 0017148
2009-08-17 10:14 Luis Ibanez Project @1@ => ITK
2009-08-17 10:14 Luis Ibanez Status new => assigned
2009-08-17 10:14 Luis Ibanez Assigned To => Bradley Lowekamp
2009-08-17 10:35 Bradley Lowekamp Status assigned => confirmed
2009-08-18 14:41 Bradley Lowekamp Note Added: 0017156
2009-08-18 14:41 Bradley Lowekamp Status confirmed => resolved
2009-08-18 14:41 Bradley Lowekamp Resolution open => fixed
2010-10-21 12:31 Gabe Hart Status resolved => closed

Copyright © 2000 - 2018 MantisBT Team