View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0009161

ITK

public

2009-06-16 10:29

2009-09-29 10:16

Reporter

Kevin H. Hobbs

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

ITK-3-16

Summary

0009161: Build warning in itkScalarConnectedComponentImageFilter.h

Description

When itkScalarConnectedComponentImageFilter.h is compiled with GCC 4.3.2 and the pixel type is int, the compiler produces a warning about the comparison between signed and unsigned integers.

This cropped up on the Farsight dashboard here :

http://www.cdash.org/CDash/viewBuildError.php?type=1&buildid=357016 [^]

I've created a minimum example program.

Stephen Aylward has suggested a fix on the farsight developers list :

http://www.kitware.com/cgi-bin/mailman/private/farsight-developers/2009-June/000113.html [^]

Tags

No tags attached.

Resolution Date

Sprint

Sprint Status

Attached Files

produces_warning.cxx [^] (403 bytes) 2009-06-16 10:29

CMakeLists.txt [^] (371 bytes) 2009-06-16 10:30 [Show Content] [Hide Content]

PROJECT( produces_warning )

cmake_minimum_required( VERSION 2.4 )

FIND_PACKAGE ( ITK )
IF ( ITK_FOUND )
	INCLUDE( ${USE_ITK_FILE} )
ENDIF( ITK_FOUND )

INCLUDE_DIRECTORIES(
	${series_SOURCE_DIR}
	)

LINK_DIRECTORIES ( 
	${series_SOURCE_DIR}
	)

ADD_EXECUTABLE( produces_warning produces_warning.cxx )
TARGET_LINK_LIBRARIES( produces_warning ITKCommon ITKBasicFilters )

itkScalarConnectedComponentImageFilter.h.signed_unsigned_int_comparison.patch [^] (848 bytes) 2009-06-16 10:49 [Show Content] [Hide Content]

Index: Code/BasicFilters/itkScalarConnectedComponentImageFilter.h
===================================================================
RCS file: /cvsroot/Insight/Insight/Code/BasicFilters/itkScalarConnectedComponentImageFilter.h,v
retrieving revision 1.8
diff -u -r1.8 itkScalarConnectedComponentImageFilter.h
--- Code/BasicFilters/itkScalarConnectedComponentImageFilter.h	1 Apr 2009 14:36:31 -0000	1.8
+++ Code/BasicFilters/itkScalarConnectedComponentImageFilter.h	16 Jun 2009 14:45:30 -0000
@@ -62,7 +62,15 @@
   
   bool operator()(const TInput &a, const TInput &b) const
     {
-    return (vnl_math_abs(a-b) <= m_Threshold);
+    TInput absDifference = static_cast<TInput>( vnl_math_abs( a-b ) );
+    if (absDifference <= m_Threshold)
+      {
+      return true;
+      }
+    else
+      {
+      return false;
+      }
     }
 
 protected:

Relationships

Notes
(0016732) Kevin H. Hobbs (developer) 2009-06-16 14:09	This experimental build was made with the change noted above. http://www.cdash.org/CDash/buildSummary.php?buildid=357192 [^]

(0017818) Marius Staring (developer) 2009-09-29 10:16	http://www.itk.org/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkScalarConnectedComponentImageFilter.h?root=Insight&r1=1.8&r2=1.9&sortby=date [^]

Issue History
Date Modified	Username	Field	Change
2009-06-16 10:29	Kevin H. Hobbs	New Issue
2009-06-16 10:29	Kevin H. Hobbs	File Added: produces_warning.cxx
2009-06-16 10:30	Kevin H. Hobbs	File Added: CMakeLists.txt
2009-06-16 10:49	Kevin H. Hobbs	File Added: itkScalarConnectedComponentImageFilter.h.signed_unsigned_int_comparison.patch
2009-06-16 14:09	Kevin H. Hobbs	Note Added: 0016732
2009-09-29 10:16	Marius Staring	Note Added: 0017818
2009-09-29 10:16	Marius Staring	Status	new => closed
2009-09-29 10:16	Marius Staring	Resolution	open => fixed
2009-09-29 10:16	Marius Staring	Fixed in Version	=> ITK-3-16