View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0009031 | CMake | CPack | public | 2009-05-14 10:39 | 2009-05-29 16:10 | ||||
Reporter | Eric NOULARD | ||||||||
Assigned To | Alex Neundorf | ||||||||
Priority | normal | Severity | major | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | CMake-2-6 | ||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0009031: CPack RPM fails on Mandriva 2009.1 because of #% comment lines | ||||||||
Description | Mandriva 2009.1 (Spring) which uses rpm 4.6.0 complains when used with current CMake 2-6 branch and/or HEAD because the CPack RPM generated spec file contains comment line beginning with #%define and the like. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | ![]() | ||||||||
Relationships | |
Relationships |
Notes | |
(0016438) Eric NOULARD (developer) 2009-05-14 10:42 |
Provided patch replaced '#%' with '#p ' which seems to calm down Mandriva 2009.1 rpm 4.6.0 error. (note that the very same version of rpm tool on Fedora Core 10 did not complain about that!!) |
(0016445) Alex Neundorf (developer) 2009-05-14 15:35 |
Aren't these lines just comments anyway ? Which meaning do #% and #p have exactly ? Alex |
(0016451) Eric NOULARD (developer) 2009-05-14 16:04 |
These are effectively comment line but I think they deserves to stay here as a reminder. They should normally be there in a "classical" spec file. the %<something> are classical spec file directives. #<whatever ...> is a comment line. Some of the %<directive> were commented because the CPack RPM spec is somehow a "shortcutted" spec: no build --> %build --> #%build no install --> %install --> #%install since Mandriva rpm 4.6.0 was complaining about #% combination I did simply search and replace #% by # p p == percent. Those lines may be safely removed but I'd like to keep them: 1) Because most of the time no-one reads the generated spec file besides me (or curious people). Thus the uglyness of those line are not read very often. 2) because it helps me (or potential contributor) to keep track of "classical" spec file %<directive> |
(0016469) Eric NOULARD (developer) 2009-05-15 03:07 |
Last small note. If you'd rather throw away comment lines with #% / #p that's fine for me. My memory is not that bad and, they will remain in the CVS history, so it's "as-you-like" |
(0016566) Eric NOULARD (developer) 2009-05-26 07:28 |
Ping. Alex, What do you want me to do? Do you want another patch with "# p" lines removed? |
(0016597) Alex Neundorf (developer) 2009-05-29 16:10 |
Patch committed to HEAD, thanks. Alex |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2009-05-14 10:39 | Eric NOULARD | New Issue | |
2009-05-14 10:40 | Eric NOULARD | File Added: bug9031-CPackRPM-erk1.patch | |
2009-05-14 10:42 | Eric NOULARD | Note Added: 0016438 | |
2009-05-14 15:35 | Alex Neundorf | Note Added: 0016445 | |
2009-05-14 16:04 | Eric NOULARD | Note Added: 0016451 | |
2009-05-15 03:07 | Eric NOULARD | Note Added: 0016469 | |
2009-05-26 07:28 | Eric NOULARD | Note Added: 0016566 | |
2009-05-28 17:57 | Alex Neundorf | Status | new => assigned |
2009-05-28 17:57 | Alex Neundorf | Assigned To | => Alex Neundorf |
2009-05-29 16:10 | Alex Neundorf | Note Added: 0016597 | |
2009-05-29 16:10 | Alex Neundorf | Status | assigned => closed |
2009-05-29 16:10 | Alex Neundorf | Resolution | open => fixed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |