View Issue Details [ Jump to Notes ]

Project

Tags

No tags attached.

CPackRPM-ctest-SimpleInstall.patch [^] (770 bytes) 2009-05-14 10:23 [Show Content] [Hide Content]

Index: Tests/SimpleInstall/CMakeLists.txt
===================================================================
RCS file: /cvsroot/CMake/CMake/Tests/SimpleInstall/CMakeLists.txt,v
retrieving revision 1.103
diff -u -r1.103 CMakeLists.txt
--- Tests/SimpleInstall/CMakeLists.txt	1 May 2009 13:45:43 -0000	1.103
+++ Tests/SimpleInstall/CMakeLists.txt	14 May 2009 14:13:44 -0000
@@ -358,6 +358,11 @@
   IF(found_bz2)
     SET(CPACK_GENERATOR "${CPACK_GENERATOR};TBZ2")
   ENDIF(found_bz2)
+  # Test CPack RPM if rpmbuild command is found
+  FIND_PROGRAM(found_rpmbuild NAMES rpmbuild)
+  IF(found_rpmbuild)
+    SET(CPACK_GENERATOR "${CPACK_GENERATOR};RPM")
+  ENDIF(found_rpmbuild)
 ENDIF(UNIX AND NOT APPLE)
 
 SET(CPACK_PACKAGE_EXECUTABLES "SimpleInstall" "Simple Install")

Relationships

Notes
(0016436) Eric NOULARD (developer) 2009-05-14 10:24	The attached patch will trigger the build of RPM package if the rpmbuild command is found, just as TBZ2 is if bzip2 command is found.

(0016486) David Cole (manager) 2009-05-15 16:13	We cannot add this test without some extra conditional logic..... I tried it just now on my Linux box and got: CPack: Compress package CMake Error at /home/davidcole/Dashboards/My Tests/CMake/Modules/CPackRPM.cmake:112 (MESSAGE): /usr/bin/rpmbuild can't handle paths with spaces, use a build directory without spaces for building RPMs. Most CMake dashboards run inside a directory called "My Tests" to ensure that everything works with spaces in the path. We would have to make a special directory somewhere else that SimpleInstall could run in in order to test rpmbuild as part of a dashboard hosted under "My Tests"....... Sorry. We can't apply this patch as is.

(0016487) David Cole (manager) 2009-05-15 16:14	Please feel free to re-open if attaching a new patch that deals with the "space in the path" issue for CMake dashboards

(0024001) David Cole (manager) 2010-12-14 18:45	Closing bugs that have been resolved for more than 3 months without any further updates.

Issue History
Date Modified	Username	Field	Change
2009-05-14 10:23	Eric NOULARD	New Issue
2009-05-14 10:23	Eric NOULARD	File Added: CPackRPM-ctest-SimpleInstall.patch
2009-05-14 10:24	Eric NOULARD	Note Added: 0016436
2009-05-15 16:13	David Cole	Note Added: 0016486
2009-05-15 16:13	David Cole	Status	new => assigned
2009-05-15 16:13	David Cole	Assigned To	=> David Cole
2009-05-15 16:14	David Cole	Note Added: 0016487
2009-05-15 16:14	David Cole	Status	assigned => resolved
2009-05-15 16:14	David Cole	Resolution	open => won't fix
2010-12-14 18:45	David Cole	Note Added: 0024001
2010-12-14 18:45	David Cole	Status	resolved => closed