View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0008990ITKpublic2009-05-09 03:392010-10-21 14:17
ReporterDaniel Mueller 
Assigned Toxiaoxiao 
PrioritynormalSeverityminorReproducibilityalways
StatusassignedResolutionopen 
PlatformOSOS Version
Product VersionITK-3-12 
Target VersionFixed in Version 
Summary0008990: FastMarchingImageFilter does not correctly handle adjacent trial points
DescriptionIn itkFastMarchingImageFilter.txx the UpdateNeighbors method checks if the candidate neighbour is an alive point. If so, then it is skipped from further processing. If not, then it is processed (ie. output value updated). This method should also test if the candidate neighbour is a *trial* point. If it is a trial point, then the output value has already been set, and does not need to be updated. Doing so will actually produce incorrect values.

See attached patch.
TagsNo tags attached.
Resolution Date
Sprint
Sprint Status
Attached Filespatch file icon itkFastMarchingImageFilter.txx.patch [^] (284 bytes) 2009-05-09 03:39 [Show Content]
patch file icon FastMarching.patch [^] (2,516 bytes) 2009-05-14 14:17 [Show Content]

 Relationships

  Notes
(0016360)
Daniel Mueller (reporter)
2009-05-09 03:41

See: http://www.itk.org/pipermail/insight-users/2009-May/030279.html [^]
(0016361)
Daniel Mueller (reporter)
2009-05-09 14:25

The patch attached to this bug is not the full story.

See: http://www.itk.org/pipermail/insight-users/2009-May/030282.html [^]

> Hi Dan,
> shouldn't you check if the update value computed for the trial point
> is smaller than the already existing value for that trial point and if
> so update it regardless?
>
> Luca
(0016443)
Daniel Mueller (reporter)
2009-05-14 14:18

See FastMarching.patch for a more complete solution
(0020370)
lantiga (developer)
2010-04-23 03:16

The fix has been committed Jan 13 2010. The bug report has been left open until a test for the issue has been submitted.
(0020371)
lantiga (developer)
2010-04-23 03:19

The fix has been committed Jan 13 2010. The bug report has been left open to remind that further testing is necessary.
(0022645)
Hans Johnson (developer)
2010-10-21 14:17

We just need to add a test for this case.

 Issue History
Date Modified Username Field Change
2009-05-09 03:39 Daniel Mueller New Issue
2009-05-09 03:39 Daniel Mueller File Added: itkFastMarchingImageFilter.txx.patch
2009-05-09 03:41 Daniel Mueller Note Added: 0016360
2009-05-09 14:25 Daniel Mueller Note Added: 0016361
2009-05-14 14:17 Daniel Mueller File Added: FastMarching.patch
2009-05-14 14:18 Daniel Mueller Note Added: 0016443
2010-01-13 09:16 lantiga Status new => assigned
2010-01-13 09:16 lantiga Assigned To => lantiga
2010-04-23 03:16 lantiga Note Added: 0020370
2010-04-23 03:19 lantiga Note Added: 0020371
2010-10-21 14:16 Hans Johnson Assigned To lantiga => xiaoxiao
2010-10-21 14:17 Hans Johnson Note Added: 0022645


Copyright © 2000 - 2018 MantisBT Team