(0015591)
Keith Gardner (reporter)
2009-03-06 11:02

in the share/cmake-2.6/Modules/NSIS.template.in file, line 34, the variable used for Name is set to "@CPACK_PACKAGE_INSTALL_DIRECTORY@"

(0015782)
Shlomi Fish (reporter)
2009-03-24 09:01

I think I've ran into this bug here:

http://www.cmake.org/pipermail/cmake/2009-March/028051.html [^]

I'll try to prepare a patch for it soon.

Regards,

-- Shlomi Fish

(0015955)
David Cole (manager)
2009-04-07 15:35

Fixed in CVS HEAD of CMake.

cvs commit -m "BUG: Fix issue 0008682. Use CPACK_NSIS_DISPLAY_NAME in appropriate places rather than CPACK_PACKAGE_INSTALL_DIRECTORY. Clean separation of these two variables (which have the same value by default) allows an easy workaround for issue 0007881, too." NSIS.template.in

/cvsroot/CMake/CMake/Modules/NSIS.template.in,v <-- NSIS.template.in
new revision: 1.36; previous revision: 1.35

(0016882)
David Cole (manager)
2009-07-16 11:50

Original fix had unintended side effects -- the CPACK_NSIS_DISPLAY_NAME variable is used as the description string for the installed package in the Windows Add/Remove Programs control panel. Using it for these other fields does not make sense for some installers.... so another new variable must be introduced to be able to fix the "separate installer name / default installer directory" problem.

(0016883)
David Cole (manager)
2009-07-16 11:52

Re-fixed in CVS HEAD of CMake.

cvs commit -m "BUG: Re-fix issue 0008682. Use new variable CPACK_NSIS_PACKAGE_NAME in appropriate places rather than CPACK_NSIS_DISPLAY_NAME. CPACK_NSIS_DISPLAY_NAME is the Add/Remove control panel's description string for the installed package. Using it as the "Name" of the NSIS installer package made the CMake installer itself use really long strings in the installer GUI. This fix still allows for the original intent of the first fix for 0008682 -- the ability to separate the installer name from the default install directory, but it uses a new/different variable to achieve the separation."

/cvsroot/CMake/CMake/Modules/CPack.cmake,v <-- CPack.cmake
new revision: 1.44; previous revision: 1.43
/cvsroot/CMake/CMake/Modules/NSIS.template.in,v <-- NSIS.template.in
new revision: 1.37; previous revision: 1.36

(0016884)
David Cole (manager)
2009-07-16 11:53

see previous note for commit logs that resolve the issue...

(0024096)
David Cole (manager)
2010-12-14 18:49

Closing bugs that have been resolved for more than 3 months without any further updates.

Issue History
Date Modified	Username	Field	Change
2009-03-06 10:51	Keith Gardner	New Issue
2009-03-06 11:02	Keith Gardner	Note Added: 0015591
2009-03-24 09:01	Shlomi Fish	Note Added: 0015782
2009-04-01 06:54	David Cole	Status	new => assigned
2009-04-01 06:54	David Cole	Assigned To	=> David Cole
2009-04-07 15:34	David Cole	Relationship added	related to 0007881
2009-04-07 15:35	David Cole	Note Added: 0015955
2009-04-07 15:35	David Cole	Status	assigned => resolved
2009-04-07 15:35	David Cole	Resolution	open => fixed
2009-07-16 11:50	David Cole	Note Added: 0016882
2009-07-16 11:50	David Cole	Status	resolved => assigned
2009-07-16 11:52	David Cole	Note Added: 0016883
2009-07-16 11:53	David Cole	Note Added: 0016884
2009-07-16 11:53	David Cole	Status	assigned => resolved
2010-12-14 18:49	David Cole	Note Added: 0024096
2010-12-14 18:49	David Cole	Status	resolved => closed

Notes
(0015591) Keith Gardner (reporter) 2009-03-06 11:02	in the share/cmake-2.6/Modules/NSIS.template.in file, line 34, the variable used for Name is set to "@CPACK_PACKAGE_INSTALL_DIRECTORY@"

(0015782) Shlomi Fish (reporter) 2009-03-24 09:01	I think I've ran into this bug here: http://www.cmake.org/pipermail/cmake/2009-March/028051.html [^] I'll try to prepare a patch for it soon. Regards, -- Shlomi Fish

(0015955) David Cole (manager) 2009-04-07 15:35	Fixed in CVS HEAD of CMake. cvs commit -m "BUG: Fix issue 0008682. Use CPACK_NSIS_DISPLAY_NAME in appropriate places rather than CPACK_PACKAGE_INSTALL_DIRECTORY. Clean separation of these two variables (which have the same value by default) allows an easy workaround for issue 0007881, too." NSIS.template.in /cvsroot/CMake/CMake/Modules/NSIS.template.in,v <-- NSIS.template.in new revision: 1.36; previous revision: 1.35

(0016882) David Cole (manager) 2009-07-16 11:50	Original fix had unintended side effects -- the CPACK_NSIS_DISPLAY_NAME variable is used as the description string for the installed package in the Windows Add/Remove Programs control panel. Using it for these other fields does not make sense for some installers.... so another new variable must be introduced to be able to fix the "separate installer name / default installer directory" problem.

(0016883) David Cole (manager) 2009-07-16 11:52	Re-fixed in CVS HEAD of CMake. cvs commit -m "BUG: Re-fix issue 0008682. Use new variable CPACK_NSIS_PACKAGE_NAME in appropriate places rather than CPACK_NSIS_DISPLAY_NAME. CPACK_NSIS_DISPLAY_NAME is the Add/Remove control panel's description string for the installed package. Using it as the "Name" of the NSIS installer package made the CMake installer itself use really long strings in the installer GUI. This fix still allows for the original intent of the first fix for 0008682 -- the ability to separate the installer name from the default install directory, but it uses a new/different variable to achieve the separation." /cvsroot/CMake/CMake/Modules/CPack.cmake,v <-- CPack.cmake new revision: 1.44; previous revision: 1.43 /cvsroot/CMake/CMake/Modules/NSIS.template.in,v <-- NSIS.template.in new revision: 1.37; previous revision: 1.36

(0016884) David Cole (manager) 2009-07-16 11:53	see previous note for commit logs that resolve the issue...

(0024096) David Cole (manager) 2010-12-14 18:49	Closing bugs that have been resolved for more than 3 months without any further updates.