| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0008649 | CMake | CPack | public | 2009-03-02 06:06 | 2016-06-10 14:30 | ||||
| Reporter | Jan Peciva | ||||||||
| Assigned To | Bill Hoffman | ||||||||
| Priority | normal | Severity | trivial | Reproducibility | always | ||||
| Status | closed | Resolution | moved | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | CMake-2-6 | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0008649: CPack fails to install when "Do not create shortcuts" | ||||||||
| Description | The problem is related to CPACK_NSIS_EXTRA_INSTALL_COMMANDS that allows to run custom application to finish installation. However, if I click "Do not create shortcuts" in Start Menu during the installation process, this command is not executed. I consider it a bug. Installation of Start Menu items must be independent on the core installation procedure. Idea of not-finalizing application installation because I did not wanted start menu items seems really bad to me. Please consider to change the behavior that is definitely buggy. I investigated solution and attaching correct NSIS.template.in The trick to fix it is just to swap these two lines: @CPACK_NSIS_EXTRA_INSTALL_COMMANDS@ !insertmacro MUI_STARTMENU_WRITE_END to !insertmacro MUI_STARTMENU_WRITE_END @CPACK_NSIS_EXTRA_INSTALL_COMMANDS@ Quick explanation: If CPACK_NSIS_EXTRA_INSTALL_COMMANDS is in the block MUI_STARTMENU_WRITE, it is mistakenly excluded from execution when "Do not create shortcuts" is checked. Thanks for fix. | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files |  NSIS.template.in [^] (18,373 bytes) 2009-03-02 06:06 | ||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0017159) Mikko Vainio (reporter) 2009-08-19 08:59 |
FYI, the fix above worked for me on Windows XP SP3 using CMake 2.6.4. |
|
(0017896) pcjohn (reporter) 2009-10-02 09:01 |
Any chance to get it fixed? |
|
(0017939) David Cole (manager) 2009-10-04 16:33 |
Fixed in CVS HEAD of CMake. /cvsroot/CMake/CMake/Modules/NSIS.template.in,v <-- Modules/NSIS.template.in new revision: 1.39; previous revision: 1.38 Assigned to Bill to merge to the CMake-2-8 branch. |
|
(0041508) Kitware Robot (administrator) 2016-06-10 14:27 |
Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page. |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| 2009-03-02 06:06 | Jan Peciva | New Issue | |
| 2009-03-02 06:06 | Jan Peciva | File Added: NSIS.template.in | |
| 2009-03-02 09:13 | Bill Hoffman | Status | new => assigned |
| 2009-03-02 09:13 | Bill Hoffman | Assigned To | => David Cole |
| 2009-08-19 08:59 | Mikko Vainio | Note Added: 0017159 | |
| 2009-10-02 09:01 | pcjohn | Note Added: 0017896 | |
| 2009-10-04 16:32 | David Cole | Assigned To | David Cole => Bill Hoffman |
| 2009-10-04 16:33 | David Cole | Note Added: 0017939 | |
| 2016-06-10 14:27 | Kitware Robot | Note Added: 0041508 | |
| 2016-06-10 14:27 | Kitware Robot | Status | assigned => resolved |
| 2016-06-10 14:27 | Kitware Robot | Resolution | open => moved |
| 2016-06-10 14:30 | Kitware Robot | Status | resolved => closed |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |