View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0007736

CDash

public

2008-09-25 10:06

2009-03-28 17:18

Reporter

Dan Thill

Assigned To

Julien Jomier

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Win32

OS Version

Product Version

Target Version

Fixed in Version

1.4

Summary

0007736: Root directory in websvn URL must have trailing slash for websvn paths to be generated correctly

Description

When setting the CVS/SVN Viewer URL, if a root is specified, it must have a trailing slash and ampersand, e.g:

pc-dthill2/websvn/listing.php?repname=Chronos&path=trunk/&

For example, if the trailing slash is omitted:

pc-dthill2/websvn/listing.php?repname=Chronos&path=trunk&

When get_websvn_diff_url() generates a URL for the file, it will not add the trailing slash, so the path is messed up:

pc-dthill2/websvn/listing.php?repname=Chronos&path=trunkApplication/src/File.cpp&

Additional Information

When defining the CVS/SVN Viewer URL, a trailing ampersand must be present, or the root isn't detected properly (common.php:2320). Maybe this should be documented?

Tags

No tags attached.

Attached Files

Relationships

Notes
(0013578) Dan Thill (reporter) 2008-09-25 10:10	Please ignore the "Additional Information" about the trailing ampersand. I misread the code.

(0014765) Julien Jomier (manager) 2009-02-03 12:53	Looks like it was a bug in the parsing of the URL. You should only need to put: pc-dthill2/websvn/listing.php?repname=Chronos&path=trunk

Issue History
Date Modified	Username	Field	Change
2008-09-25 10:06	Dan Thill	New Issue
2008-09-25 10:10	Dan Thill	Note Added: 0013578
2009-02-03 12:48	Julien Jomier	Status	new => assigned
2009-02-03 12:48	Julien Jomier	Assigned To	=> Julien Jomier
2009-02-03 12:53	Julien Jomier	Note Added: 0014765
2009-02-03 12:53	Julien Jomier	Status	assigned => resolved
2009-02-03 12:53	Julien Jomier	Fixed in Version	=> 1.4
2009-02-03 12:53	Julien Jomier	Resolution	open => fixed
2009-03-28 17:18	Julien Jomier	Status	resolved => closed