View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0007470

CMake

CPack

public

2008-08-07 18:30

2010-12-14 18:45

Reporter

Greg Peele

Assigned To

David Cole

Priority

normal

Severity

block

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

CMake-2-6

Target Version

Fixed in Version

Summary

0007470: CPack NSIS Generator fails if filenames contain spaces

Description

The NSIS generator puts too many quotes around filenames with spaces in the uninstaller portion of the NSIS script. This causes NSIS installer generation to fail.

Suppose that you have a file that you want to install as follows:

INSTALL (FILES "Config File.xml" DESTINATION bin/config COMPONENT RUNTIME)

The NSIS generator will fail with the following error in the NSIS log:

Delete expects 1-2 parameters, got 6.

Tracing down the actual line in the NSIS script that causes the error, it produces a line as follows in macro Remove_${RUNTIME}.

Delete "$INSTDIR\"bin\config\Config File.xml""

Tags

No tags attached.

Attached Files

CMake.patch [^] (1,662 bytes) 2008-12-17 13:53 [Show Content] [Hide Content]

Index: cmCPackNSISGenerator.cxx
===================================================================
RCS file: /cvsroot/CMake/CMake/Source/CPack/cmCPackNSISGenerator.cxx,v
retrieving revision 1.38
diff -u -r1.38 cmCPackNSISGenerator.cxx
--- cmCPackNSISGenerator.cxx	10 Oct 2008 21:08:00 -0000	1.38
+++ cmCPackNSISGenerator.cxx	17 Dec 2008 18:37:41 -0000
@@ -797,17 +797,27 @@
        pathIt != component->Files.end(); 
        ++pathIt) 
     {
-    macrosOut << "  Delete \"$INSTDIR\\" 
-              << cmSystemTools::ConvertToWindowsOutputPath(pathIt->c_str())
-              << "\"\n";
+    std::string windowsPath = cmSystemTools::ConvertToWindowsOutputPath(pathIt->c_str());
+    // remove quotes from conversion
+    if(windowsPath[0] == '\"')
+      {
+      windowsPath.erase(0,1);
+      windowsPath.erase(windowsPath.size()-1,1);
+      }
+    macrosOut << "  Delete \"$INSTDIR\\" << windowsPath << "\"\n";
     }
   for (pathIt = component->Directories.begin(); 
        pathIt != component->Directories.end(); 
        ++pathIt) 
     {
-    macrosOut << "  RMDir \"$INSTDIR\\" 
-              << cmSystemTools::ConvertToWindowsOutputPath(pathIt->c_str())
-              << "\"\n";
+    std::string windowsPath = cmSystemTools::ConvertToWindowsOutputPath(pathIt->c_str());
+    // remove quotes from conversion
+    if(windowsPath[0] == '\"')
+      {
+      windowsPath.erase(0,1);
+      windowsPath.erase(windowsPath.size()-1,1);
+      }
+    macrosOut << "  RMDir \"$INSTDIR\\" << windowsPath << "\"\n";
     }
   macrosOut << "  noremove_" << component->Name << ":\n";
   macrosOut << "!macroend\n";

Relationships

Notes
(0014386) Clinton Stimpson (developer) 2008-12-17 13:53	Its a blocker for me too. I've attached a patch to fix it.

(0014387) Bill Hoffman (manager) 2008-12-17 15:41	Dave can you apply this?

(0014644) David Cole (manager) 2009-01-20 14:33	Fixed in CVS HEAD: /cvsroot/CMake/CMake/Source/CPack/cmCPackNSISGenerator.cxx,v <-- Source/CPack/cmCPackNSISGenerator.cxx new revision: 1.39; previous revision: 1.38 /cvsroot/CMake/CMake/Tests/CPackComponents/CMakeLists.txt,v <-- Tests/CPackComponents/CMakeLists.txt new revision: 1.4; previous revision: 1.3 /cvsroot/CMake/CMake/Tests/CPackComponents/Issue 7470.html,v <-- Tests/CPackComponents/Issue 7470.html initial revision: 1.1 I did not apply the patch, but fixed it in a simpler way, eliminating the call to the otherwise-not-directly-called ConvertToWindowsOutputPath function. Added a test, too, to make sure it stays fixed.

(0024024) David Cole (manager) 2010-12-14 18:45	Closing bugs that have been resolved for more than 3 months without any further updates.

Issue History
Date Modified	Username	Field	Change
2008-08-07 18:30	Greg Peele	New Issue
2008-08-07 19:09	Bill Hoffman	Status	new => assigned
2008-08-07 19:09	Bill Hoffman	Assigned To	=> Douglas Gregor
2008-12-17 13:53	Clinton Stimpson	File Added: CMake.patch
2008-12-17 13:53	Clinton Stimpson	Note Added: 0014386
2008-12-17 15:41	Bill Hoffman	Assigned To	Douglas Gregor => David Cole
2008-12-17 15:41	Bill Hoffman	Note Added: 0014387
2009-01-20 14:33	David Cole	Note Added: 0014644
2009-01-20 14:33	David Cole	Status	assigned => resolved
2009-01-20 14:33	David Cole	Resolution	open => fixed
2010-12-14 18:45	David Cole	Note Added: 0024024
2010-12-14 18:45	David Cole	Status	resolved => closed