View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0007285 | CMake | Modules | public | 2008-07-04 13:19 | 2016-06-10 14:30 | ||||
Reporter | Miguel Figueroa | ||||||||
Assigned To | Miguel Figueroa | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | moved | ||||||
Platform | OS | OS Version | |||||||
Product Version | CMake-2-6 | ||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0007285: Fix for FindXMLRPC to obey REQUIRED keyword | ||||||||
Description | Reported by Alexander Bubnov: http://www.cmake.org/pipermail/cmake/2008-July/022616.html [^] I have attached a patch to fix this, please apply or send me a note to do so myself. --Miguel | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | FindXMLRPC.cmake.patch [^] (3,247 bytes) 2008-07-04 13:19 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0013088) Bill Hoffman (manager) 2008-08-19 16:53 |
Why is the patch so big? Seems like it should only have: +INCLUDE(FindPackageHandleStandardArgs) +FIND_PACKAGE_HANDLE_STANDARD_ARGS( + XMLRPC "${FAIL_MSG}" XMLRPC_C_CONFIG XMLRPC_INCLUDE_DIRS XMLRPC_LIBRARIES XMLRPC_FOUND) |
(0013093) Miguel Figueroa (developer) 2008-08-19 18:12 |
IIRC, the process was printing an error message at each iteration if a component wasn't found. So, I'm basically collecting this error message if any and let find_package_handle_standard_args handle it. Note that if QUIET was passed, then no message should be printed. I also removed a piece of code that was setting XMLRPC_FOUND, since this is supposed to be set by find_package_handle_standard_args. This required the condition in the IF to be changed. Finally, XMLRPC_<component>_FOUND variables were set as required by the standard. So, should I commit this? --Miguel |
(0013098) Bill Hoffman (manager) 2008-08-19 21:53 |
Sure as long as you test it. |
(0013099) Bill Hoffman (manager) 2008-08-19 21:54 |
OH, and I assume it still sets the same variables as it did before so it does not break backwards compatibility right? Thanks for helping with the modules! |
(0041437) Kitware Robot (administrator) 2016-06-10 14:27 |
Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2008-07-04 13:19 | Miguel Figueroa | New Issue | |
2008-07-04 13:19 | Miguel Figueroa | File Added: FindXMLRPC.cmake.patch | |
2008-08-19 16:53 | Bill Hoffman | Status | new => assigned |
2008-08-19 16:53 | Bill Hoffman | Assigned To | => Bill Hoffman |
2008-08-19 16:53 | Bill Hoffman | Assigned To | Bill Hoffman => Miguel Figueroa |
2008-08-19 16:53 | Bill Hoffman | Note Added: 0013088 | |
2008-08-19 18:12 | Miguel Figueroa | Note Added: 0013093 | |
2008-08-19 21:53 | Bill Hoffman | Note Added: 0013098 | |
2008-08-19 21:54 | Bill Hoffman | Note Added: 0013099 | |
2016-06-10 14:27 | Kitware Robot | Note Added: 0041437 | |
2016-06-10 14:27 | Kitware Robot | Status | assigned => resolved |
2016-06-10 14:27 | Kitware Robot | Resolution | open => moved |
2016-06-10 14:30 | Kitware Robot | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |