View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0007235 | CMake | CMake | public | 2008-06-24 08:56 | 2016-06-10 14:30 | ||||
Reporter | Adam Strzelecki | ||||||||
Assigned To | Bill Hoffman | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | moved | ||||||
Platform | OS | OS Version | |||||||
Product Version | CMake-2-6 | ||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0007235: RC generation broken for MinGW, causes infinite loop for CL (Microsoft compiler) (w/patch) | ||||||||
Description | MinGW does have only Microsoft's RC recipe for generating resource files using "rc" command, while MinGW uses its own "windres". Moreover latest enable_language change causes infinite loop in Windows-cl.cmake that enables RC language: [103] /opt/local/share/cmake-2.6/Modules/Platform/Windows-cl.cmake [102] /opt/local/share/cmake-2.6/Modules/CMakeSystemSpecificInformation.cmake [101] /opt/local/share/cmake-2.6/Modules/Platform/Windows-cl.cmake [100] /opt/local/share/cmake-2.6/Modules/CMakeSystemSpecificInformation.cmake [99] /opt/local/share/cmake-2.6/Modules/Platform/Windows-cl.cmake [98] /opt/local/share/cmake-2.6/Modules/CMakeSystemSpecificInformation.cmake [97] /opt/local/share/cmake-2.6/Modules/Platform/Windows-cl.cmake [96] /opt/local/share/cmake-2.6/Modules/CMakeSystemSpecificInformation.cmake Removing ENABLE_LANGUAGE(RC) from Windows-cl.cmake solves the problem. Adding COMPILE_RC_OBJECT definition to Windows-gcc makes it use "windres" properly. I've added also "windres" to CMakeDetermineRCCompiler.cmake, however it has different command line, that is specified next to compiler (Windows-gcc.cmake or cl.cmake), so it may be a problem when we have mixed environment and "rc" will be taken from Microsoft env,(1st in the list) while gcc from MingW will be requested. I'm not sure how to sort it out. So this patch needs review. Anyway it is not possible to build RC files with MinGW with 2.6.0 so I believe it should fixed before 2.6.1. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files | ![]() | ||||||||
Relationships | |
Relationships |
Notes | |
(0012505) Bill Hoffman (manager) 2008-06-24 15:55 |
I have removed the optional for RC, that caused the infinite stuff. Turns out for embeded resources stuff, we use the rc compiler as well, so we have to have it. I will look at the patch, we want to make sure that gcc uses windres and cl uses rc right? |
(0012509) Adam Strzelecki (reporter) 2008-06-24 17:03 |
> we want to make sure that gcc uses windres and cl uses rc right? Exactly. Moreover gcc's windres has different than cl's rc syntax: <windres> --input-format rc --output-format coff -I<includes> -i<input> -o<output> |
(0013189) Michał Fita (reporter) 2008-08-26 13:18 |
What is additional important thing, it could not accept path with spaces as argv[0] (simialar to g++). I found CMakeSetup sets my CMAKE_CXX_COMPILER to C:\Progra~1\MinGW\bin\g++.exe. Similar for mingw32-make.exe. If this is intentional, should be intentional same way for windres.exe. I hope it would be released soon corrected. I need this very much. |
(0037060) Timothy Gu (reporter) 2014-10-21 20:09 |
This bug has been partially addressed by http://www.cmake.org/gitweb?p=cmake.git;a=commit;h=b2f308c8f9b4ded77f0693b39c0288e3bbb00977 [^] , but the solution is not complete, as the scripts must be manually included in CMakeLists.txt. I have sent a patch fixing this issue: http://public.kitware.com/pipermail/cmake-developers/2014-October/011728.html [^] |
(0041433) Kitware Robot (administrator) 2016-06-10 14:27 |
Resolving issue as `moved`. This issue tracker is no longer used. Further discussion of this issue may take place in the current CMake Issues page linked in the banner at the top of this page. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2008-06-24 08:56 | Adam Strzelecki | New Issue | |
2008-06-24 08:56 | Adam Strzelecki | File Added: CMake_broken_RC_generation.patch | |
2008-06-24 15:55 | Bill Hoffman | Note Added: 0012505 | |
2008-06-24 17:03 | Adam Strzelecki | Note Added: 0012509 | |
2008-08-21 09:01 | Bill Hoffman | Status | new => assigned |
2008-08-21 09:01 | Bill Hoffman | Assigned To | => Bill Hoffman |
2008-08-26 13:18 | Michał Fita | Note Added: 0013189 | |
2014-10-21 20:09 | Timothy Gu | Note Added: 0037060 | |
2016-06-10 14:27 | Kitware Robot | Note Added: 0041433 | |
2016-06-10 14:27 | Kitware Robot | Status | assigned => resolved |
2016-06-10 14:27 | Kitware Robot | Resolution | open => moved |
2016-06-10 14:30 | Kitware Robot | Status | resolved => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |