View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0007123

CMake

Modules

public

2008-05-29 14:14

2008-06-10 22:24

Reporter

tanguy_k

Assigned To

Clinton Stimpson

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

no change required

Platform

OS Version

Product Version

CMake-2-6

Target Version

Fixed in Version

Summary

0007123: QT_DEBUG define should be moved from UseQt4.cmake to FindQt4.cmake

Description

I noticed that QT_DEBUG and QT_NO_DEBUG are quite important flags.

In the case of Phonon backends, it was impossible to load a backend (== a Qt plugin) compiled with MinGW without QT_DEBUG/QT_NO_DEBUG being defined.
This issue was detected only with MinGW, it worked fine with MSVC and Linux/GCC. Once the flags QT_DEBUG/QT_NO_DEBUG were added, the problem was solved.
This typically a kind of issue very difficult to solve, who thinks about a define not there when it works using other compilers/OS?

For the full story about how the problem was detected: http://groups.google.com/group/phonon-vlc-mplayer/browse_thread/thread/334efdff70fab22f [^]

How can other people not get into QT_DEBUG/QT_NO_DEBUG issue:
- QT_DEBUG/QT_NO_DEBUG are defined inside UseQt4.cmake
- a lot of libraries/apps only use FindQt4.cmake without using UseQt4.cmake

The solution I propose is to move QT_DEBUG/QT_NO_DEBUG definitions to FindQt4.cmake in order to prevent this.

Patch attached

Tags

No tags attached.

Attached Files

FindQt4_QT_DEBUG.diff [^] (1,834 bytes) 2008-05-29 14:14 [Show Content] [Hide Content]

Index: FindQt4.cmake
===================================================================
--- FindQt4.cmake	(revision 165)
+++ FindQt4.cmake	(working copy)
@@ -157,9 +157,8 @@
 #
 #  QT_DEFINITIONS   Definitions to use when compiling code that uses Qt.
 #                   You do not need to use this if you include QT_USE_FILE.
-#                   The QT_USE_FILE will also define QT_DEBUG and QT_NO_DEBUG
-#                   to fit your current build type.  Those are not contained
-#                   in QT_DEFINITIONS.
+#                   QT_DEFINITIONS defines QT_DEBUG and QT_NO_DEBUG to fit
+#                   your current build type.
 #                  
 #  QT_INCLUDES      List of paths to all include directories of 
 #                   Qt4 QT_INCLUDE_DIR and QT_QTCORE_INCLUDE_DIR are
@@ -261,7 +260,12 @@
 
 SET(QT_USE_FILE ${CMAKE_ROOT}/Modules/UseQt4.cmake)
 
-SET( QT_DEFINITIONS "")
+SET(QT_DEFINITIONS "")
+IF(CMAKE_BUILD_TYPE STREQUAL Debug)
+  SET(QT_DEFINITIONS ${QT_DEFINITIONS} -DQT_DEBUG)
+ELSEIF(NOT CMAKE_BUILD_TYPE STREQUAL Debug)
+  SET(QT_DEFINITIONS ${QT_DEFINITIONS} -DQT_NO_DEBUG)
+ENDIF(CMAKE_BUILD_TYPE STREQUAL Debug)
 
 SET(QT4_INSTALLED_VERSION_TOO_OLD FALSE)
 
Index: UseQt4.cmake
===================================================================
--- UseQt4.cmake	(revision 164)
+++ UseQt4.cmake	(working copy)
@@ -5,10 +5,6 @@
 
 
 ADD_DEFINITIONS(${QT_DEFINITIONS})
-SET_PROPERTY(DIRECTORY APPEND PROPERTY COMPILE_DEFINITIONS_DEBUG QT_DEBUG)
-SET_PROPERTY(DIRECTORY APPEND PROPERTY COMPILE_DEFINITIONS_RELEASE QT_NO_DEBUG)
-SET_PROPERTY(DIRECTORY APPEND PROPERTY COMPILE_DEFINITIONS_RELWITHDEBINFO QT_NO_DEBUG)
-SET_PROPERTY(DIRECTORY APPEND PROPERTY COMPILE_DEFINITIONS_MINSIZEREL QT_NO_DEBUG)
 
 INCLUDE_DIRECTORIES(${QT_INCLUDE_DIR})

Relationships

Notes
(0012314) Clinton Stimpson (developer) 2008-06-10 22:24	There's no way to properly put it in the FindQt4.cmake and without adding an extra burden on the user. Using the UseQt4.cmake is the best way to go. Or, just copy the few lines that set QT_NO_DEBUG/QT_DEBUG in UseQt4.cmake into your own CMakeLists.txt file.

Issue History
Date Modified	Username	Field	Change
2008-05-29 14:14	tanguy_k	New Issue
2008-05-29 14:14	tanguy_k	File Added: FindQt4_QT_DEBUG.diff
2008-06-06 11:11	Bill Hoffman	Status	new => assigned
2008-06-06 11:11	Bill Hoffman	Assigned To	=> Clinton Stimpson
2008-06-10 22:24	Clinton Stimpson	Status	assigned => closed
2008-06-10 22:24	Clinton Stimpson	Note Added: 0012314
2008-06-10 22:24	Clinton Stimpson	Resolution	open => no change required