View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0006617 | ITK | public | 2008-03-16 01:55 | 2011-01-13 17:00 | |||||
Reporter | Bing Jian | ||||||||
Assigned To | Stephen Aylward | ||||||||
Priority | normal | Severity | feature | Reproducibility | have not tried | ||||
Status | closed | Resolution | reopened | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | Fixed in Version | ||||||||
Summary | 0006617: Unable to Read/Write AcquisitionDate | ||||||||
Description | According to Luis's reply to my question on Mar 14, 2008 "This seems to be a bug in the MetaImage library, The file Insight/Utilities/MetaImage/metaObject.cxx in line 1130, takes care of reading this field: MET_InitReadField(mF, "AcquisitionDate", MET_STRING, false); as part of the method: M_SetupReadFields(void) but is misses to write it as part of the method: M_SetupWriteFields(void) It seems that we are missing a line like: mF = new MET_FieldRecordType; MET_InitWriteField(mF, "AcquisitionDate", MET_STRING, strlen(m_ObjectTypeName), m_ObjectTypeName); around lines 1272. | ||||||||
Additional Information | Fix committed to SVN. Used patch from Tom. | ||||||||
Tags | No tags attached. | ||||||||
Resolution Date | |||||||||
Sprint | |||||||||
Sprint Status | |||||||||
Attached Files | ![]() ![]() | ||||||||
Relationships | |
Relationships |
Notes | |
(0011198) Stephen Aylward (developer) 2008-04-08 19:13 |
Change required is a bit more than listed. A candidate solution is being tested. |
(0011200) Stephen Aylward (developer) 2008-04-09 06:10 |
Code in CVS |
(0011605) Stephen Aylward (developer) 2008-04-30 11:10 |
Fixed and submitted to cvs |
(0020823) Tom Vercauteren (developer) 2010-05-26 13:57 |
This bug appears not to be fixed. A simple test like this one: MetaObject mobj("test.txt"); mobj.AcquisitionDate( "26-05-2010" ); mobj.Write(); generates the following file: ObjectType = Object NDims = 0 BinaryData = False TransformMatrix = Offset = CenterOfRotation = ElementSpacing = The culprit is a missing m_Fields.push_back(mF); after the MET_InitWriteField(mF, "AcquisitionDate", [...] ) A patch is attached. |
(0020856) Tom Vercauteren (developer) 2010-05-28 10:13 |
I also encountered a valgrind issue with AcquisitionDate. It seems that the string was not always null terminated which led to problems with strlen. The updated patch (2010-05-28) should fix this issue as well. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2008-03-16 01:55 | Bing Jian | New Issue | |
2008-04-08 19:13 | Stephen Aylward | Status | new => assigned |
2008-04-08 19:13 | Stephen Aylward | Assigned To | => Stephen Aylward |
2008-04-08 19:13 | Stephen Aylward | Note Added: 0011198 | |
2008-04-08 19:13 | Stephen Aylward | Status | assigned => confirmed |
2008-04-09 06:10 | Stephen Aylward | Note Added: 0011200 | |
2008-04-30 11:10 | Stephen Aylward | Status | confirmed => resolved |
2008-04-30 11:10 | Stephen Aylward | Resolution | open => fixed |
2008-04-30 11:10 | Stephen Aylward | Note Added: 0011605 | |
2010-05-26 13:57 | Tom Vercauteren | Note Added: 0020823 | |
2010-05-26 13:57 | Tom Vercauteren | Status | resolved => feedback |
2010-05-26 13:57 | Tom Vercauteren | Resolution | fixed => reopened |
2010-05-26 14:00 | Tom Vercauteren | File Added: metaio-acqdate-2010-05-25.patch | |
2010-05-28 10:12 | Tom Vercauteren | File Added: metaio-acqdate-2010-05-28.patch | |
2010-05-28 10:13 | Tom Vercauteren | Note Added: 0020856 | |
2010-05-28 16:33 | Stephen Aylward | Status | feedback => resolved |
2010-05-28 16:33 | Stephen Aylward | Additional Information Updated | |
2010-10-21 12:31 | Gabe Hart | Status | resolved => closed |
2011-01-13 17:00 | Source_changeset_attached | => VTK master a2bd8391 | |
2011-01-13 17:00 | Source_changeset_attached | => VTK master 020ef709 |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |