(0010626)
Philip Lowman (developer)
2008-02-21 21:04

I recently learned of the existence of CMAKE_PREFIX_PATH. This really makes the introducing a module that relies on something like a variable called CXXTEST_ROOT_DIR to find header files and programs kinda stupid. I have therefore removed the CXXTEST_ROOT_DIR behavior from the module.

I have also modified the module to work with the new CMAKE_RUNTIME_OUTPUT_DIRECTORY variable if specified, and to prefer it to EXECUTABLE_OUTPUT_PATH.

Resubmitted as IMPROVED_FindCxxTest.cmake

(0011776)
Philip Lowman (developer)
2008-05-09 13:55

Any possibility of getting this included with CMake?

(0011803)
Alex Neundorf (developer)
2008-05-11 05:17

Yes, the problem is just, I never used CxxTest before. If I add this to cvs, I will have to maintain it, and I don't really feel competent for that.

Would you be willing to maintain this module ? This would mean you would get cvs write account to Modules/ and will have to care for that module then.

Alex

(0011807)
Philip Lowman (developer)
2008-05-11 11:36

I'm willing to maintain the module and any other modules that I contribute back to CMake.

(0011808)
Alex Neundorf (developer)
2008-05-11 12:12

Please contact Bill Hoffman with the request for maintaining this module.
Here you can find more information:
http://www.cmake.org/Wiki/CMake:Module_Maintainers [^]

Alex

(0014305)
Philip Lowman (developer)
2008-12-07 22:43

updated one more time with minor bugfixes && contacting Bill

(0014331)
Philip Lowman (developer)
2008-12-11 22:07

Committed, please feel free to close this bug.

Committer: Philip Lowman <philip@yhbt.com>
/cvsroot/CMake/CMake/Modules/FindCxxTest.cmake,v <-- FindCxxTest.cmake
initial revision: 1.1

(0014334)
Alex Neundorf (developer)
2008-12-13 18:11

Thanks :-)

I had a quick look, it contains:

INCLUDE(FindPackageHandleStandardArgs)
FIND_PACKAGE_HANDLE_STANDARD_ARGS(CxxTest DEFAULT_MSG CXXTEST_INCLUDE_DIR)
IF(CXXTEST_INCLUDE_DIR)
SET(CXXTEST_INCLUDE_DIRS ${CXXTEST_INCLUDE_DIR})
SET(CXXTEST_FOUND true)
ENDIF(CXXTEST_INCLUDE_DIR)

You don't have to set CXXTEST_FOUND there, this is already done by FIND_PACKAGE_HANDLE_STANDARD_ARGS (if all given arguments are true).
I think you can just do
SET(CXXTEST_INCLUDE_DIRS ${CXXTEST_INCLUDE_DIR})
without any if() around it.

Alex

Issue History
Date Modified	Username	Field	Change
2008-02-21 00:38	Philip Lowman	New Issue
2008-02-21 00:38	Philip Lowman	File Added: FindCxxTest.cmake
2008-02-21 12:11	Alex Neundorf	Status	new => assigned
2008-02-21 12:11	Alex Neundorf	Assigned To	=> Alex Neundorf
2008-02-21 21:04	Philip Lowman	File Added: IMPROVED_FindCxxTest.cmake
2008-02-21 21:04	Philip Lowman	Note Added: 0010626
2008-05-09 13:55	Philip Lowman	Note Added: 0011776
2008-05-11 05:17	Alex Neundorf	Note Added: 0011803
2008-05-11 11:36	Philip Lowman	Note Added: 0011807
2008-05-11 12:12	Alex Neundorf	Note Added: 0011808
2008-12-07 22:43	Philip Lowman	File Added: IMPROVED2_FindCxxTest.cmake
2008-12-07 22:43	Philip Lowman	Note Added: 0014305
2008-12-11 22:07	Philip Lowman	Note Added: 0014331
2008-12-13 18:11	Alex Neundorf	Note Added: 0014334
2008-12-13 18:11	Alex Neundorf	Status	assigned => closed
2008-12-13 18:11	Alex Neundorf	Resolution	open => fixed

Notes
(0010626) Philip Lowman (developer) 2008-02-21 21:04	I recently learned of the existence of CMAKE_PREFIX_PATH. This really makes the introducing a module that relies on something like a variable called CXXTEST_ROOT_DIR to find header files and programs kinda stupid. I have therefore removed the CXXTEST_ROOT_DIR behavior from the module. I have also modified the module to work with the new CMAKE_RUNTIME_OUTPUT_DIRECTORY variable if specified, and to prefer it to EXECUTABLE_OUTPUT_PATH. Resubmitted as IMPROVED_FindCxxTest.cmake

(0011776) Philip Lowman (developer) 2008-05-09 13:55	Any possibility of getting this included with CMake?

(0011803) Alex Neundorf (developer) 2008-05-11 05:17	Yes, the problem is just, I never used CxxTest before. If I add this to cvs, I will have to maintain it, and I don't really feel competent for that. Would you be willing to maintain this module ? This would mean you would get cvs write account to Modules/ and will have to care for that module then. Alex

(0011807) Philip Lowman (developer) 2008-05-11 11:36	I'm willing to maintain the module and any other modules that I contribute back to CMake.

(0011808) Alex Neundorf (developer) 2008-05-11 12:12	Please contact Bill Hoffman with the request for maintaining this module. Here you can find more information: http://www.cmake.org/Wiki/CMake:Module_Maintainers [^] Alex

(0014305) Philip Lowman (developer) 2008-12-07 22:43	updated one more time with minor bugfixes && contacting Bill

(0014331) Philip Lowman (developer) 2008-12-11 22:07	Committed, please feel free to close this bug. Committer: Philip Lowman <philip@yhbt.com> /cvsroot/CMake/CMake/Modules/FindCxxTest.cmake,v <-- FindCxxTest.cmake initial revision: 1.1

(0014334) Alex Neundorf (developer) 2008-12-13 18:11	Thanks :-) I had a quick look, it contains: INCLUDE(FindPackageHandleStandardArgs) FIND_PACKAGE_HANDLE_STANDARD_ARGS(CxxTest DEFAULT_MSG CXXTEST_INCLUDE_DIR) IF(CXXTEST_INCLUDE_DIR) SET(CXXTEST_INCLUDE_DIRS ${CXXTEST_INCLUDE_DIR}) SET(CXXTEST_FOUND true) ENDIF(CXXTEST_INCLUDE_DIR) You don't have to set CXXTEST_FOUND there, this is already done by FIND_PACKAGE_HANDLE_STANDARD_ARGS (if all given arguments are true). I think you can just do SET(CXXTEST_INCLUDE_DIRS ${CXXTEST_INCLUDE_DIR}) without any if() around it. Alex

Relationships