View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0006073

ITK

public

2007-11-21 13:46

2007-11-21 19:30

Reporter

Luis Ibanez

Assigned To

Luis Ibanez

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Summary

0006073: Filters related to Orientation were inconsistent

Description

Flip, PermuteAxes, Orient ImageFilter need reviews on how to manage the origin and directions.

Additional Information

BUG: FlipImageFilter - Managing directions and the sign of the origin needs to be done differently for FlipAboutOrigin and not.
BUG: FlipImageFilter - Use TransformIndexToPhysicalPoint() to account for orientations effect on the new origin
BUG: PermuteAxesImageFilter - should not permute the origin. the new image needs to occupy the same space as the old image. Only spacing, direction, and regions should permute.
BUG: OrientImageFilter - Flip filter used in the mini-pipeline needed to have FlipAboutOrigin = false. Was done in the GenerateOutputInformation() method but also needed in the GenerateData() method.

Tags

No tags attached.

Resolution Date

Sprint

Sprint Status

Attached Files

Relationships

Notes
(0009726) Luis Ibanez (manager) 2007-11-21 13:53	Jim committed fixes for these filters to the main repository. The filters however seem to be under-tested, since the problems were not making any test fail.

(0009727) Luis Ibanez (manager) 2007-11-21 14:49	The fixes have been ported to the ITK 3.4 branch: http://www.itk.org/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkPermuteAxesImageFilter.txx?r1=1.14&root=Insight&sortby=date&r2=1.14.6.1&only_with_tag=ITK-3-4 [^] http://www.itk.org/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkFlipImageFilter.txx?r1=1.15&root=Insight&sortby=date&r2=1.15.6.1&only_with_tag=ITK-3-4 [^] http://www.itk.org/cgi-bin/viewcvs.cgi/Code/BasicFilters/itkOrientImageFilter.txx?r1=1.15&root=Insight&sortby=date&r2=1.15.2.1&only_with_tag=ITK-3-4 [^]

(0009729) Luis Ibanez (manager) 2007-11-21 19:30	An experimental submission of ITK 3.4 was green

Issue History
Date Modified	Username	Field	Change
2007-11-21 13:46	Luis Ibanez	New Issue
2007-11-21 13:48	Luis Ibanez	Assigned To	=> Luis Ibanez
2007-11-21 13:48	Luis Ibanez	Status	new => assigned
2007-11-21 13:53	Luis Ibanez	Note Added: 0009726
2007-11-21 14:49	Luis Ibanez	Note Added: 0009727
2007-11-21 19:30	Luis Ibanez	Status	assigned => closed
2007-11-21 19:30	Luis Ibanez	Note Added: 0009729
2007-11-21 19:30	Luis Ibanez	Resolution	open => fixed