| View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0005173 | ITK | public | 2007-06-13 03:03 | 2007-06-13 12:44 | |||||
| Reporter | Steve Robbins | ||||||||
| Assigned To | Mathieu Malaterre | ||||||||
| Priority | low | Severity | minor | Reproducibility | always | ||||
| Status | closed | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | |||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0005173: ITKConfig.cmake should not export SOURCE DIR | ||||||||
| Description | The file ITKConfig.cmake is installed so that other cmake-using sources can properly find ITK's libs and includes. This file may be installed from a binary packaging on a system that doesn't have ITK sources. So there is no need to define ITK_SOURCE_DIR. The patch included removes this. | ||||||||
| Tags | No tags attached. | ||||||||
| Resolution Date | |||||||||
| Sprint | |||||||||
| Sprint Status | |||||||||
| Attached Files |  04_ITKConfig.patch [^] (440 bytes) 1969-12-31 19:00 [Show Content]
| ||||||||
| Relationships | |
| Relationships |
| Notes | |
|
(0007866) Mathieu Malaterre (developer) 2007-06-13 12:40 |
More comments from Steve: It is both useless and misleading, IMHO. Imagine you installed a binary packaging of ITK (say, from Debian) that includes the ITKConfig.cmake file. The source code is not on your machine, so this variable is completely useless. The danger is that a naive developer of an ITK-based software package may use this variable to get at something (maybe a header file) without realising it. The software builds fine on her machine, but not on my machine that doesn't have ITK source. The presence of this variable may mislead someone into using it. |
|
(0007867) Mathieu Malaterre (developer) 2007-06-13 12:44 |
$ cvs ci -m"ENH: Fix Bug 0005173 - ITKConfig.cmake should not export SOURCE DIR. This value will point nowhere in a true installation (without source). Since VTK does not expose VTK_SOURCE_DIR either, simply remove it in ITK" ITKConfig.cmake.in /cvsroot/Insight/Insight/ITKConfig.cmake.in,v <-- ITKConfig.cmake.in new revision: 1.20; previous revision: 1.19 |
| Notes |
| Issue History | |||
| Date Modified | Username | Field | Change |
| Issue History |
| Copyright © 2000 - 2018 MantisBT Team |